Flavor names unnecessarily restrictive

[Chris St. Pierre]

Flavor names are restricted to "word" characters, period, dash, and space, for no apparent reason. Flavor names should allow all printable characters to obviate this unnecessary restriction. If nothing else, this will make it easier to migrate from pre-Grizzly (I know, ancient history) where the allowable flavor name regex was less restrictive.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119741

[Sean Dague (sdague)]

This seems like something which should come out to the mailing list. This restriction was added to create more consistency throughout OpenStack, and reversing it is something I'm quite concerned about.

[Chris St. Pierre (stpierre)]

The feedback I got on my proposed change (
https://review.openstack.org/#/c/119741/) was that this should happen
consistently, for all resources, which I agree with -- undoing consistency
is never a good thing. I've updated my patch accordingly, and will have a
Tempest patch shortly that fixes the test that's failing there, too.

This is actually a forward-port of an internal patch we had against
Grizzly, where the name restrictions weren't consistent, which is why the
bug is phrased as it is. I don't see a particular downside to loosening the
restrictions on resource names as long as it happens across the board.

On Wed, Sep 10, 2014 at 11:07 AM, Sean Dague <email address hidden> wrote:

> This seems like something which should come out to the mailing list.
> This restriction was added to create more consistency throughout
> OpenStack, and reversing it is something I'm quite concerned about.
>
> ** Changed in: nova
> Importance: Undecided => Wishlist
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1366778
>
> Title:
> Flavor names unnecessarily restrictive
>
> Status in OpenStack Compute (Nova):
> In Progress
>
> Bug description:
> Flavor names are restricted to "word" characters, period, dash, and
> space, for no apparent reason. Flavor names should allow all printable
> characters to obviate this unnecessary restriction. If nothing else,
> this will make it easier to migrate from pre-Grizzly (I know, ancient
> history) where the allowable flavor name regex was less restrictive.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova/+bug/1366778/+subscriptions
>

--
Chris St. Pierre
Senior Software Engineer
metacloud.com

[Ken'ichi Ohmichi (oomichi)]

For avoiding ping-pong(add/remove this limitation), I feel it is necessary to discuss what should be acceptable string characters for OpenStack.
This limitation exists in long term already, and I don't now(in the rest of Juno) is good time for this change.

[Ken'ichi Ohmichi (oomichi)]

A related ticket is https://bugs.launchpad.net/nova/+bug/977187

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/119741
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119741
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f40b6a1d5c91628f78fdbc0417a3a394a69ab716
Submitter: Jenkins
Branch: master

commit f40b6a1d5c91628f78fdbc0417a3a394a69ab716
Author: Chris St. Pierre <email address hidden>
Date: Fri Sep 5 15:12:51 2014 -0400

    Expand valid resource name character set

    This allows all printable unicode characters and horizontal whitespace
    characters in resource names (flavors, aggregates, cells, etc.), as
    opposed to the rather limited set that was previously available. This
    follows the principle of not creating unnecessary restrictions.

    Implements: blueprint relax-resource-name-restrictions
    Closes-Bug: 1366778
    Change-Id: I35104852797dcba4594af4361bf9226e16bfb114