[browser] Update visual design of the new tab page
Bug #1351157 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
webbrowser-app |
Fix Released
|
Medium
|
Riccardo Padovani | ||
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Ugo Riboni | ||
webbrowser-app (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The visual design of the new tab page doesn’t fully match the visual spec:
- the "see more" / "see less" actions for bookmarks should be in the section header
- the layout should be different when in landscape mode
--- --- --- ---
UX Comment 1:
Fix Released Partial - Correct UX/visuals for portrait working as per spec, but same UX/visuals also present in landscape mode (landscape has different UX & visuals):
https:/
--- --- --- ---
UX Comment 2:
Correct Landscape UX/Visuals are currently WIP by engineers.
Related branches
lp:~rpadovani/webbrowser-app/newTabRefactoring
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 773 lines (+351/-279)6 files modifiedsrc/app/webbrowser/Browser.qml (+59/-59)
src/app/webbrowser/NewTabView.qml (+200/-126)
src/app/webbrowser/UrlsList.qml (+72/-93)
src/app/webbrowser/bookmarks-model.cpp (+3/-1)
src/app/webbrowser/bookmarks-model.h (+2/-0)
tests/unittests/bookmarks-model/tst_BookmarksModelTests.cpp (+15/-0)
lp:~uriboni/webbrowser-app/new-tab-wide-format
- Olivier Tilloy: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 1928 lines (+1244/-153)21 files modifieddebian/control (+1/-0)
src/app/webbrowser/Browser.qml (+63/-27)
src/app/webbrowser/DraggableUrlDelegateWide.qml (+98/-0)
src/app/webbrowser/NewTabViewWide.qml (+317/-0)
src/app/webbrowser/UrlDelegateWide.qml (+86/-0)
src/app/webbrowser/bookmarks-folder-model.cpp (+21/-1)
src/app/webbrowser/bookmarks-folder-model.h (+1/-0)
src/app/webbrowser/bookmarks-folderlist-model.cpp (+5/-0)
src/app/webbrowser/bookmarks-folderlist-model.h (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+77/-4)
tests/autopilot/webbrowser_app/tests/__init__.py (+8/-2)
tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+2/-6)
tests/autopilot/webbrowser_app/tests/test_bookmark_options.py (+32/-46)
tests/autopilot/webbrowser_app/tests/test_findinpage.py (+1/-2)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+121/-43)
tests/autopilot/webbrowser_app/tests/test_private.py (+8/-13)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+2/-6)
tests/unittests/bookmarks-folder-model/tst_BookmarksFolderModelTests.cpp (+6/-3)
tests/unittests/qml/CMakeLists.txt (+9/-0)
tests/unittests/qml/tst_NewTabViewWide.qml (+372/-0)
tests/unittests/qml/tst_QmlTests.cpp (+12/-0)
lp:~osomon/webbrowser-app/wide-views-newtab-history
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 3866 lines (+2910/-200)39 files modifieddebian/control (+1/-0)
src/app/webbrowser/Browser.qml (+133/-66)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/DraggableUrlDelegateWide.qml (+98/-0)
src/app/webbrowser/HistorySectionDelegate.qml (+6/-4)
src/app/webbrowser/HistoryViewWide.qml (+418/-0)
src/app/webbrowser/NewTabViewWide.qml (+317/-0)
src/app/webbrowser/UrlDelegate.qml (+8/-1)
src/app/webbrowser/UrlDelegateWide.qml (+86/-0)
src/app/webbrowser/UrlsList.qml (+2/-2)
src/app/webbrowser/bookmarks-folder-model.cpp (+21/-1)
src/app/webbrowser/bookmarks-folder-model.h (+1/-0)
src/app/webbrowser/bookmarks-folderlist-model.cpp (+5/-0)
src/app/webbrowser/bookmarks-folderlist-model.h (+2/-0)
src/app/webbrowser/history-lastvisitdate-model.cpp (+93/-0)
src/app/webbrowser/history-lastvisitdate-model.h (+60/-0)
src/app/webbrowser/history-lastvisitdatelist-model.cpp (+210/-0)
src/app/webbrowser/history-lastvisitdatelist-model.h (+72/-0)
src/app/webbrowser/history-model.cpp (+15/-0)
src/app/webbrowser/history-model.h (+1/-0)
src/app/webbrowser/webbrowser-app.cpp (+4/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+81/-5)
tests/autopilot/webbrowser_app/tests/__init__.py (+8/-2)
tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+2/-6)
tests/autopilot/webbrowser_app/tests/test_bookmark_options.py (+32/-46)
tests/autopilot/webbrowser_app/tests/test_findinpage.py (+1/-2)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+121/-43)
tests/autopilot/webbrowser_app/tests/test_private.py (+8/-13)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+2/-6)
tests/unittests/CMakeLists.txt (+2/-0)
tests/unittests/bookmarks-folder-model/tst_BookmarksFolderModelTests.cpp (+6/-3)
tests/unittests/history-lastvisitdate-model/CMakeLists.txt (+11/-0)
tests/unittests/history-lastvisitdate-model/tst_HistoryLastVisitDateModelTests.cpp (+116/-0)
tests/unittests/history-lastvisitdatelist-model/CMakeLists.txt (+11/-0)
tests/unittests/history-lastvisitdatelist-model/tst_HistoryLastVisitDateListModelTests.cpp (+371/-0)
tests/unittests/qml/CMakeLists.txt (+11/-0)
tests/unittests/qml/tst_HistoryViewWide.qml (+184/-0)
tests/unittests/qml/tst_NewTabViewWide.qml (+372/-0)
tests/unittests/qml/tst_QmlTests.cpp (+16/-0)
tags: | added: ota-1 |
Changed in ubuntu-ux: | |
assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
status: | New → Fix Committed |
importance: | Undecided → Low |
tags: | removed: rtm14 |
summary: |
- Update visual design of the new tab page + [browser] Update visual design of the new tab page |
Changed in ubuntu-ux: | |
importance: | Low → Medium |
tags: | added: design-gap |
Changed in webbrowser-app: | |
assignee: | Olivier Tilloy (osomon) → nobody |
Changed in webbrowser-app (Ubuntu): | |
status: | New → Confirmed |
Changed in webbrowser-app (Ubuntu RTM): | |
status: | New → Confirmed |
Changed in webbrowser-app: | |
assignee: | nobody → Riccardo Padovani (rpadovani) |
status: | Triaged → In Progress |
tags: |
added: newtab removed: ota-1 |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
Changed in ubuntu-ux: | |
assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
description: | updated |
description: | updated |
Changed in webbrowser-app (Ubuntu): | |
status: | Fix Released → Triaged |
Changed in webbrowser-app (Ubuntu RTM): | |
status: | Fix Released → Triaged |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Ugo Riboni (uriboni) |
importance: | Undecided → High |
status: | Triaged → In Progress |
description: | updated |
description: | updated |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+15. 10.20150602- 0ubuntu1
--------------- 10.20150602- 0ubuntu1) wily; urgency=medium
webbrowser-app (0.23+15.
[ CI Train Bot ]
* New rebuild forced.
[ Olivier Tilloy ] qmlplugin to 1.6 to fix unit
* Actually clear the network cache by deleting the correct set of
files in the correct directory. (LP: #1459956)
* Bump build dependency on liboxideqt-
tests.
* Do not cache favicons on disk when browsing in private mode. (LP:
#1458963)
* Do not try to remove a file that doesn’t exist.
* Pass plain strings to the worker script instead of RegExps. (LP:
#1445673)
* Remove the upstreamcomponents folder, and use components from the
UITK instead. Add autopilot tests for the new tab view.
* Update translation template.
* Updated icon. (LP: #1457424)
[ Riccardo Padovani ]
* New tab view refactoring. (LP: #1371248, #1444023, #1351157,
#1389605, #1442190)
* New tab view refactoring. (LP: #1371248, #1444023, #1351157,
#1389605, #1442190)
-- CI Train Bot <email address hidden> Tue, 02 Jun 2015 14:26:50 +0000