maas does not combine kernel_opts when nodes have multiple tags with kernel options
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Low
|
Alberto Donato |
Bug Description
1. will attach if needed
2. $ dpkg -l '*maas*'|cat
Desired=
| Status=
|/ Err?=(none)
||/ Name Version Architecture Description
+++-===
ii maas 1.5.1+bzr2269-
ii maas-cli 1.5.1+bzr2269-
ii maas-cluster-
ii maas-common 1.5.1+bzr2269-
ii maas-dhcp 1.5.1+bzr2269-
ii maas-dns 1.5.1+bzr2269-
ii maas-region-
ii maas-region-
ii python-django-maas 1.5.1+bzr2269-
ii python-maas-client 1.5.1+bzr2269-
ii python-
3.
a) maas $user tags new name=disable_
b) maas $user tags new name=enable_console kernel_
c) maas $user tag update-nodes disable_biosdevname add=$node1_
d) maas $user tag update-nodes enable_console add=$node1_
e) maas $user node start $node1_system_id
f) check /proc/cmdline on $node1_system_id
Expected result:
$node1_system_id boots with kernel params: console=
Actual result:
$node1_system_id boots with kernel params: net.ifnames=1 biosdevname=0
Related branches
- Adam Collard (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 299 lines (+57/-95)9 files modifiedsrc/maasserver/api/examples/tags.json (+2/-2)
src/maasserver/api/tags.py (+3/-3)
src/maasserver/migrations/maasserver/0230_tag_kernel_opts_blank_instead_of_null.py (+19/-0)
src/maasserver/models/node.py (+10/-20)
src/maasserver/models/tag.py (+1/-1)
src/maasserver/models/tests/test_node.py (+16/-49)
src/maasserver/models/tests/test_tag.py (+1/-1)
src/maasserver/rpc/boot.py (+4/-18)
src/maasserver/testing/factory.py (+1/-1)
Changed in maas: | |
milestone: | none → next |
Changed in maas: | |
assignee: | nobody → Alberto Donato (ack) |
milestone: | next → none |
status: | New → In Progress |
Changed in maas: | |
milestone: | none → 2.10-beta1 |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Right now, the first tag (lexicographical order) with a non-empty kernel_opts field wins. Concatenating all the kernel_opts of the node's tags makes more sense indeed.