Comment 4 for bug 1335175

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> The rule that the first tag with options wins (and also overrides global options) is arbitrary, there to provide some predictability,
> but if we switch to combining tags we then need to make an arbitrary choice of which order in which to combine them
> (assuming it matters).

I agree; we should order the tags before we concatenate the kernel_opts so that the end result can be fine-tuned by the user.

> Another problem arises if two or more tags have conflicting kernel options

Right, but this is all under the user's control so I don't see that as a problem. As long as the resulting kernel_opt line is predictable and exposed in the UI/API (for verification), I think it's fine to concatenate the kernel_opts as it gives the user more leeway.