On 01/07/14 23:34, Ryan Harper wrote:
> My preference would be to not bother checking for overlap and let the
> user control. If there is simple concat, then the user can accept the
> overlap, or modify the kernel_opts in the tag. Having maas do more
> things to the options than just joining could have more side-effects.
But in which order should it concat the options? Because this will
affect way in which the kernel sees them.
IoW I don't think this is as simple as a straight concat.
> I'd really not like tag creation/update to fail if some other user
> happened to define tag with one of the kernel opts I wanted to us.
Remember that only admins can tag nodes. So restricting to one tag that
has kernel options is not that big a deal.
On 01/07/14 23:34, Ryan Harper wrote:
> My preference would be to not bother checking for overlap and let the
> user control. If there is simple concat, then the user can accept the
> overlap, or modify the kernel_opts in the tag. Having maas do more
> things to the options than just joining could have more side-effects.
But in which order should it concat the options? Because this will
affect way in which the kernel sees them.
IoW I don't think this is as simple as a straight concat.
> I'd really not like tag creation/update to fail if some other user
> happened to define tag with one of the kernel opts I wanted to us.
Remember that only admins can tag nodes. So restricting to one tag that
has kernel options is not that big a deal.