Unity Scopes Scope

Appearance attributes not supported for remote scopes

Bug #1319712 reported by Michał Karnicki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity Scopes Scope
Fix Released
High
Paweł Stołowski
unity-scopes-api
Fix Released
High
Paweł Stołowski
unity-scope-scopes (Ubuntu)
Fix Released
Undecided
Paweł Stołowski

Bug Description

Appearance attributes returned for remote server scopes are not parsed and handled by scopes API, and not honored by scopes scope.

See original description

Related branches

lp:~stolowski/unity-scopes-api/remote-scopes-appearance
Michi Henning (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Marcus Tomlinson (community): Approve
Diff: 130 lines (+23/-8)
8 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+3/-2)
demo/client.cpp (+5/-4)
include/unity/scopes/internal/smartscopes/SmartScopesClient.h (+1/-0)
src/scopes/internal/smartscopes/SSRegistryObject.cpp (+5/-0)
src/scopes/internal/smartscopes/SmartScopesClient.cpp (+5/-0)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/FakeSss.py (+1/-1)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+2/-0)
lp:~stolowski/unity-scope-scopes/use-appearance-attributes
James Henstridge: Approve
Diff: 60 lines (+8/-13)
3 files modified
CMakeLists.txt (+1/-1)
debian/control (+1/-1)
src/scopes-scope.cpp (+6/-11)
lp:ubuntu/utopic-proposed/unity-scope-scopes
Paweł Stołowski (stolowski)
summary: - Take card background and icon from the yaml config file
+ Appearance attributes not supported for remote scopes
Changed in unity-scopes-api:
assignee: nobody → Pawel Stolowski (stolowski)
importance: Undecided → High
status: New → In Progress
description: updated
Paweł Stołowski (stolowski)
Changed in unity-scope-scopes:
status: New → In Progress
assignee: nobody → Pawel Stolowski (stolowski)
importance: Undecided → High
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-scopes-api/devel at revision 343, scheduled for release in unity-scopes-api, milestone Unknown

Changed in unity-scopes-api:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scope-scopes - 0.1+14.10.20140521.2-0ubuntu1

---------------
unity-scope-scopes (0.1+14.10.20140521.2-0ubuntu1) utopic; urgency=low

  [ James Henstridge ]
  * Save non-recommendations online results, and push them out after
    merging the recommendations with local scopes results. (LP:
    #1312887)

  [ Pawel Stolowski ]
  * Use background value from appearance attributes exposed in
    ScopeMetadata. Requires latest scopes-api. (LP: #1319712)
  * Don't use scope_id, search_query and scope_department from the
    result anymore, use canned query returned by the server. Don't set
    interception flag on the results, as they can now be directly
    activated by the shell. (LP: #1321728)
 -- Ubuntu daily release <email address hidden> Wed, 21 May 2014 15:32:43 +0000

Changed in unity-scope-scopes (Ubuntu):
status: New → Fix Released
James Henstridge (jamesh)
Changed in unity-scope-scopes (Ubuntu):
assignee: nobody → Pawel Stolowski (stolowski)
Changed in unity-scope-scopes:
status: In Progress → Fix Released
Michal Hruby (mhr3)
Changed in unity-scopes-api:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.