Ubuntu UI Toolkit

Tabs current selection changes when pushed down a PageStack

Bug #1316736 reported by Michael Hall on 2014-05-06

This bug affects 3 people

	Status	Importance	Assigned to
Ubuntu UI Toolkit	Fix Released	Critical	Tim Peeters
ubuntu-ui-toolkit (Ubuntu)	Fix Released	Undecided	Unassigned
Vivid	New	Undecided	Unassigned

Bug Description

If you place a Tabs component as the first page in a PageStack, as suggested in the API docs[1], the selected tab will be reset to the first tab if you push a page on top of it and then go back.

App that experiences this problem: https://code.launchpad.net/~mhall119/loco-team-portal/ubuntu-app

This is a regression, utopic r2 worked correctly (selected tab remained selected), but in r13 the selected tab changes back to the first.

I also encounter it on my desktop (trusty) once I switched on the SDK PPA, I don't recall it happening when I was using the SDK packages in the trusty archives.

[1] http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Components.Tabs/

See original description

Tags:

Related branches

lp:~tpeeters/ubuntu-ui-toolkit/popToTabs

Merged into lp:ubuntu-ui-toolkit/staging at revision 1042

PS Jenkins bot: Approve (continuous-integration) on 2014-05-09

Florian Boucault (community): Approve on 2014-05-09

Nekhelesh Ramananthan (community): Approve (testing) on 2014-05-09

lp:ubuntu/utopic-proposed/ubuntu-ui-toolkit

Michael Hall (mhall119) on 2014-05-06

tags:	added: header tabs
description:	updated

Revision history for this message

Michael Hall (mhall119) wrote on 2014-05-06:

loco-teams-app.log Edit (4.2 KiB, text/plain)

Attached is what is printed to the console when running my app from the commandline.

description:

updated

Tim Peeters (tpeeters) on 2014-05-06

Changed in ubuntu-ui-toolkit:
assignee:	nobody → Tim Peeters (tpeeters)
importance:	Undecided → High

Revision history for this message

Tim Peeters (tpeeters) wrote on 2014-05-07:

do you have a small test program that exposes the bug?

Tim Peeters (tpeeters) on 2014-05-09

Changed in ubuntu-ui-toolkit:
importance:	High → Critical

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-05-09:

12:15 PM <nik90> t1mp: with the old headers, in the clock app, when I go to the add alarm page by pushing a page into the pagestack, when I press back it does not return to the original Alarm tab. But instead it returns to the clock tab
12:15 PM <nik90> t1mp: so Clock Tab -> Alarm Tab -> Push Page to go into Add Alarm Page -> Press Back Button -> Returns to the Clock Tab
12:15 PM <nik90> t1mp: this bug is not happening with the new headers
12:32 PM <t1mp> nik90: is it this bug? https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1316736
12:32 PM <nik90> t1mp: yup that's the bug
12:33 PM <nik90> t1mp: can we raise its priority since it is causing all my alarms tests to fail essentially blocking code merges
12:33 PM <t1mp> nik90: I didn't realize that it happens with the old tabs only.. that's a regression

Tim Peeters (tpeeters) on 2014-05-09

Changed in ubuntu-ui-toolkit:
status:	New → In Progress

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-09:

Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-05-13:

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+14.10.20140512-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+14.10.20140512-0ubuntu1) utopic; urgency=low

  [ Tarmac ]
  * [ Tim Peeters ] Make it possible to replace the title in the header
    with a.   custom Item. (LP: #1316736, #1208833, #1314948)
-- Ubuntu daily release <email address hidden> Mon, 12 May 2014 12:27:41 +0000