[FFe] LMMS 1.0.0

[Israel Dahl]

I think it is necessary to get this version of LMMS into the repos, as it has many bug fixes, and HUGE overall improvements, and performance improvements.
Since Trusty is an LTS, I think the newest available version should get in.

I have contacted the LMMS-devel list to get a detailed report on the changes, and the testimonies of people who have been testing it.

On a superficial level, it has gnome Mime-type icons, a better icon, and a much improved interface.
https://screenshots.debian.net/image/10591_large.png

Everything I have used has worked fine, and quite a few things work much better (better performance, fixed some massive leaks, etc...) There are new plugins (sfxr for one). The program is now more responsive as well.

I will be attaching the pbuilder log as well

[Israel Dahl (israeldahl)]

pbuilder log

[unfa (unfa00)]

I agree. It would be a big loss to not have the new LMMS in the new release!

[Oskar Wallgren (oskar-wallgren13)]

The version is now 0.9.92 which is the third and last beta before release 1.0.0 which is probably only a week away.
The amounts of fixes and work put into the package is just amazing.
It would be really good for both LMMS and Ubuntu it the 1.0.0 release (...or 0.9.92/third beta) is included in the new Ubuntu LTS release.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Stian A (stianahj)]

Oh, good!

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Israel Dahl (israeldahl)]

This is the exhaustive list of things fixed and improved
(I hope I got them all)

[socceroos (skduff)]

Agreed! Looking forward to having the new LMMS version in the new Ubuntu release.

[Iain Lane (laney)]

Could you please attached the proposed package that you'll be wanting sponsored?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Israel Dahl (israeldahl)]

I am currently reworking a part of the install process to separate out wine dependancy into its own package, so users who don't use VST, and don't want wine can safely install the program.
I will post a link to that version soon... but the original proposal is the same branch I had proposed for merger. But I would much rather get this other very important feature in, as it will benefit all future versions (in terms of packaging efforts and user installation)
Once I am satisfied with the state of the vst branch I am working on I will link that one in as well.

[Israel Dahl (israeldahl)]

The vst branch is becoming to complicated to fix everything before a reasonable time.
So I am proposing the 0.9.92 branch instead.
There are a few more fixes (such as one that surpresses the global menu bar which messes up the UI and creates bugs)

I was unable to get the VST package working right, so I am proposing one that doesn't change the way the package manager interacts with it (except the overhaul of the debian folder, using Rodney Dawes rules file, changing compat to current, updating the standards, and adding the new depends on the fltk libs)

[Tobias Junghans (tobydox)]

LMMS 1.0.0 is going to be released this weekend so please wait for it before approving the feature freeze exception.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Martin Pitt (pitti)]

Still waiting for FFE approval.

[Scott Kitterman (kitterman)]

Note that the release team is still waiting to see the packaging changes.

[Israel Dahl (israeldahl)]

@Scott what do you mean about still waiting to see packaging changes?
Please tell me the steps I need to go through to get this worked out completely.
I had just figured at this point, the package wouldn't be allowed in, as I hadn't heard anything...

[Scott Kitterman (kitterman)]

The last comment from a release team member was this one: https://bugs.launchpad.net/lmms/+bug/1291675/comments/9

At this point, if the Ubuntu Studio team want it in, we can still get it in if the package is available very soon (by Saturday at the absolute latest), but since lmms is shipped as part of Studio, then I think it's really their opinion that matters most.

[Kaj Ailomaa (zequence)]

Just gave the ppa package a try. Seems to work very nicely.

Ok from me!

[Scott Kitterman (kitterman)]

OK. Based on that (zequence is the Ubuntu Studio release manager), I'll ack the FFe for the release team and leave it to sponsors to review the packaging changes.

[Tobias Junghans (tobydox)]

Sounds great! I suggest to include the following patches:

https://github.com/LMMS/lmms/commit/2c19290fab404baf2f31e87d0c3786ff6e3c4bf9
https://github.com/LMMS/lmms/commit/2ab5b1da0ceb05ed9001ff06b1da9453b28c17db
https://github.com/LMMS/lmms/commit/5b29142c284c68d3a7e56c007ec0517f8f941391

in order to fix some crashes. Besides these the situation is quite calm since the 1.0.0 release so it looks like 1.0.0 is quite stable.

[Scott Kitterman (kitterman)]

To get this in, someone needs to prepare a package that can be sponsored.

[Israel Dahl (israeldahl)]

I have been trying to upload a package, but the automated builder to make a new PPA keeps crashing on me... I can pbuild it just fine on my machine, but for some reason there is an issue...
https://launchpadlibrarian.net/172375834/buildlog.txt.gz
ERROR: bzrlib.errors.BzrCommandError: Generating tar from delta failed
the checksum validation fails every time I try to build...

I am pushing to a new branch including Toby's fixes

lp:/~israeldahl/ubuntu/trusty/lmms/lmms_1.0.0

It should be available soon if anyone wants to check it out. I had fix-crash on close already applied and built it earlier just fine with pbuilder, but it failed on lp. The other two patches are applied in this branch, but I have yet to test it building (though it should work the same, as these are src changes not packaging) If anyone can help spot my issue of why it crashes launchpad's builder I'd appreciate it greatly. Thanks!!

[Timo Jyrinki (timo-jyrinki)]

Thanks for your work so far! Could I get testing done quickly with Ubuntu 14.04 LTS at https://launchpad.net/~timo-jyrinki/+archive/ppa ?

sudo apt-add-repository ppa:timo-jyrinki/ppa
sudo apt-get update
sudo apt-get install lmms-common lmms

I needed to do a bunch of fixing to get it into buildable form:
- The sources at lp:~israeldahl/ubuntu/trusty/lmms/lmms_1.0.0 didn't correctly match the upstream 1.0.0+bzr2569 from lp:lmms since some patch(es) were incorrectly preapplied (or not preapplied).
- Removed upstream_fixes, as after syncing that particaular fix/file was already included in the orig tarball ie upstream snapshot.
- Added back the one patch from git that was still missing after this all, ie. Fix-broken-command-line-rendering.-Should-always-che.patch

Now what is at lp:~timo-jyrinki/lmms/1.0.0_packaging is good in the senses that a) it builds with bzr bd and PPA, b) orig tarball matches lp:lmms sources correctly, c) all the discussed patches should be included.

I've also double-checked that the orig tarball / lp:lmms bzr2569 matches upstream master branch git commit 255b2a2f49c2c02e728588b2eb3cc8c196468e93, and is essentially 1.0 release with a couple of additional fixes. The Ubuntu packaging in turn adds two more fixes that were not in master at the time of bzr2569.

The package is not lintian clean, but neither is the old package or the one in Debian, so I guess at this point it should be good enough.

If testing is positive, please upload with:
dget https://launchpad.net/~timo-jyrinki/+archive/ppa/+files/lmms_1.0.0%2Bbzr2569-0ubuntu1.dsc
+ dput. The bzr branch lp:~timo-jyrinki/lmms/1.0.0_packaging suits too.

[Kaj Ailomaa (zequence)]

I tried the latest ppa build (1.0.0+bzr2569-0ubuntu1) using jack, alsa and pulseaudio, with both internal and ladspa plugins. Works great, so +1 from me.

[Timo Jyrinki (timo-jyrinki)]

Thanks for testing. Aside from the lintian ugliness (also present in the current version in archives) if wanted to be fixed this would be ready for upload.

[Israel Dahl (israeldahl)]

It seems to work just fine here!
It doesn't crash when it closes, and everything seems to be in order in
my quick test.
Thanks for getting every patch applied correctly, I appreciate it very much!

I am learning how to package things little by little, so I am glad you
helped to get this in and fixed!! Lets merge it please!!

side note:
I thought 0.4.15 was lintian clean (or at least I got rid of any lintian
errors when using buildeb), what other way do you check?

On 04/10/2014 04:54 AM, Timo Jyrinki wrote:
> Thanks for your work so far! Could I get testing done quickly with
> Ubuntu 14.04 LTS at https://launchpad.net/~timo-jyrinki/+archive/ppa ?
>
> sudo apt-add-repository ppa:timo-jyrinki/ppa
> sudo apt-get update
> sudo apt-get install lmms-common lmms
>
> I needed to do a bunch of fixing to get it into buildable form:
> - The sources at lp:~israeldahl/ubuntu/trusty/lmms/lmms_1.0.0 didn't correctly match the upstream 1.0.0+bzr2569 from lp:lmms since some patch(es) were incorrectly preapplied (or not preapplied).
> - Removed upstream_fixes, as after syncing that particaular fix/file was already included in the orig tarball ie upstream snapshot.
> - Added back the one patch from git that was still missing after this all, ie. Fix-broken-command-line-rendering.-Should-always-che.patch
>
> Now what is at lp:~timo-jyrinki/lmms/1.0.0_packaging is good in the
> senses that a) it builds with bzr bd and PPA, b) orig tarball matches
> lp:lmms sources correctly, c) all the discussed patches should be
> included.
>
> I've also double-checked that the orig tarball / lp:lmms bzr2569 matches
> upstream master branch git commit
> 255b2a2f49c2c02e728588b2eb3cc8c196468e93, and is essentially 1.0 release
> with a couple of additional fixes. The Ubuntu packaging in turn adds two
> more fixes that were not in master at the time of bzr2569.
>
> The package is not lintian clean, but neither is the old package or the
> one in Debian, so I guess at this point it should be good enough.
>
> If testing is positive, please upload with:
> dget https://launchpad.net/~timo-jyrinki/+archive/ppa/+files/lmms_1.0.0%2Bbzr2569-0ubuntu1.dsc
> + dput. The bzr branch lp:~timo-jyrinki/lmms/1.0.0_packaging suits too.
>

[Israel Dahl (israeldahl)]

+1 from me, I simply want this to get in for all the HUGE improvements it brings.
I've tested it using this packaging for quite a while, and so have many others.
The only difference is you applied the patches (correctly :)
which have also been tested by the lmms-dev community.
All in all I say this is a great improvement.
lint can be cleaned up by october, as the usability of this program, and stableness has gone through the roof!
please merge!!!

[Timo Jyrinki (timo-jyrinki)]

0.4.15 wasn't clean as in "no warnings" either, but this new one has, in addition to various warnings, two errors that I now re-checked were actually not there in the previous release. 1.0.0 .deb package now ships a shlibs file while it doesn't have actual shared libs, probably a side-product of the debian/rules cleaning that was done. Additionally it's missing the xpm icon of the previous version, which is technically still required instead of png for menu items.

Neither of those issues are very big ones, but we'd still need a MOTU or a core-dev to sponsor the current packaging (or improve on it). I've pinged #ubuntu-devel and I'll also send a short note to the mailing list.

[Timo Jyrinki (timo-jyrinki)]

I silenced the lintian errors in the branch now.

[Adam Conrad (adconrad)]

Someone needs to get this uploaded ASAP if you guys want it in.

[Julian Taylor (jtaylor)]

uploaded with minor changes to the changelog and patch descriptions

[Launchpad Janitor (janitor)]

This bug was fixed in the package lmms - 1.0.0+bzr2569-0ubuntu1

---------------
lmms (1.0.0+bzr2569-0ubuntu1) trusty; urgency=high

  * New upstream release based on git commit 255b2a2f49c2

  [ Israel Dahl ]
  * fix-crash-on-close: (Filipe Coelho)
  * debian/rules: tiny version (Rodney Dawes)
  * debian/compat: 9
  * debian/menu: name * LMMS
  * debian/control: removed obsolete builddeps, added fltk libs... suggest
    fluid-soundfont-gm
  * Completely redesigned default theme and UI style
  * New splash screen and logo
  * New plugins:
    - DynamicsProcessor
    - sfxr
    - OpulenZ, an FM synth for LMMS
    - Waveshaper
    - Dual Filter
    - vocoder LADSPA plugin
  * AudioFileProcessor: added stutter playback mode
  * Added time display widget
  * Added support for vector-based automations with various interpolation
    methods
  * Added config option to enable waveform display by default
  * Added more controls to Peak Controller
  * Added standard paths to file open/save dialog
  * LFO controller: added support for custom waveforms
  * New file dialogs allowing for project versioning
  * Added pitch range support for instruments
  * Vestige: Path to VST plugins stored as relative, if opened from
    default VST plugin path
  * Song, SongEditor, BB-Editor, Piano-Roll: correction of play button problems
  * Display key presses in Piano Roll
  * Save solo states for tracks
  * Fixed envelope sustain response
  * Add support for upgrading presets
  * Added optional drawing of note names in Piano Roll
  * Improved overall performance by switching of FX processing if input
    is silent - you might need to tweak the FX decay knobs
  * Use Kicker as default instrument in B+B-Editor
  * Added option for unlinking all controls to context menu of controls
  * Fixed various build issues related to ZynAddSubFX, VST support etc.
  * Atomically write project files via overwrite-by-rename to prevent
    data loss upon disk failures
  * Timeline: allow right click + shift to move left loop point
  * Fixed various MIDI-related issues
  * Default MIDI velocity to 63 for volume=100%
  * CLANG compatibility
  * Hide contents of envelope/LFO tab and display info about
    single-streamed instruments instead
  * Knob code improvement: make the acceleration curve smoother
    and less "sudden" (exponential response curve for smoothing operation)
  * File dialog: Common places added to left pane
  * New mime-type icons
  * Native Amplifier plugin
  * Added support for loading 32-bit samples
  * Fixed oversampling and other problems in export

  [ Timo Jyrinki ]
  * Rework to be according to (LP: #1291675)
  * Sync sources to match the bzr snapshot tarball.
  * Refresh fix-crash-on-close.patch to apply.
  * Apply and remove upstream_fixes patch, already included in the upstream
    snapshot.
  * Fix-broken-command-line-rendering.-Should-always-che.patch:
    - Add from git as suggested
  * AutomatableModel-always-fit-value-from-linked-model.patch:
    - Replace the old patch with a format-patch version from git, but
      unapplied as already included in the bzr snapshot
  * Drop lib64-builddir.patch, seems obsolete
  * debian/lmms.lintian-overrides:
    - O...