It seems to work just fine here!
It doesn't crash when it closes, and everything seems to be in order in
my quick test.
Thanks for getting every patch applied correctly, I appreciate it very much!
I am learning how to package things little by little, so I am glad you
helped to get this in and fixed!! Lets merge it please!!
side note:
I thought 0.4.15 was lintian clean (or at least I got rid of any lintian
errors when using buildeb), what other way do you check?
On 04/10/2014 04:54 AM, Timo Jyrinki wrote:
> Thanks for your work so far! Could I get testing done quickly with
> Ubuntu 14.04 LTS at https://launchpad.net/~timo-jyrinki/+archive/ppa ?
>
> sudo apt-add-repository ppa:timo-jyrinki/ppa
> sudo apt-get update
> sudo apt-get install lmms-common lmms
>
> I needed to do a bunch of fixing to get it into buildable form:
> - The sources at lp:~israeldahl/ubuntu/trusty/lmms/lmms_1.0.0 didn't correctly match the upstream 1.0.0+bzr2569 from lp:lmms since some patch(es) were incorrectly preapplied (or not preapplied).
> - Removed upstream_fixes, as after syncing that particaular fix/file was already included in the orig tarball ie upstream snapshot.
> - Added back the one patch from git that was still missing after this all, ie. Fix-broken-command-line-rendering.-Should-always-che.patch
>
> Now what is at lp:~timo-jyrinki/lmms/1.0.0_packaging is good in the
> senses that a) it builds with bzr bd and PPA, b) orig tarball matches
> lp:lmms sources correctly, c) all the discussed patches should be
> included.
>
> I've also double-checked that the orig tarball / lp:lmms bzr2569 matches
> upstream master branch git commit
> 255b2a2f49c2c02e728588b2eb3cc8c196468e93, and is essentially 1.0 release
> with a couple of additional fixes. The Ubuntu packaging in turn adds two
> more fixes that were not in master at the time of bzr2569.
>
> The package is not lintian clean, but neither is the old package or the
> one in Debian, so I guess at this point it should be good enough.
>
> If testing is positive, please upload with:
> dget https://launchpad.net/~timo-jyrinki/+archive/ppa/+files/lmms_1.0.0%2Bbzr2569-0ubuntu1.dsc
> + dput. The bzr branch lp:~timo-jyrinki/lmms/1.0.0_packaging suits too.
>
It seems to work just fine here!
It doesn't crash when it closes, and everything seems to be in order in
my quick test.
Thanks for getting every patch applied correctly, I appreciate it very much!
I am learning how to package things little by little, so I am glad you
helped to get this in and fixed!! Lets merge it please!!
side note:
I thought 0.4.15 was lintian clean (or at least I got rid of any lintian
errors when using buildeb), what other way do you check?
On 04/10/2014 04:54 AM, Timo Jyrinki wrote: /launchpad. net/~timo- jyrinki/ +archive/ ppa ? jyrinki/ ppa command- line-rendering. -Should- always- che.patch e728588b2eb3cc8 c196468e93, and is essentially 1.0 release /launchpad. net/~timo- jyrinki/ +archive/ ppa/+files/ lmms_1. 0.0%2Bbzr2569- 0ubuntu1. dsc
> Thanks for your work so far! Could I get testing done quickly with
> Ubuntu 14.04 LTS at https:/
>
> sudo apt-add-repository ppa:timo-
> sudo apt-get update
> sudo apt-get install lmms-common lmms
>
> I needed to do a bunch of fixing to get it into buildable form:
> - The sources at lp:~israeldahl/ubuntu/trusty/lmms/lmms_1.0.0 didn't correctly match the upstream 1.0.0+bzr2569 from lp:lmms since some patch(es) were incorrectly preapplied (or not preapplied).
> - Removed upstream_fixes, as after syncing that particaular fix/file was already included in the orig tarball ie upstream snapshot.
> - Added back the one patch from git that was still missing after this all, ie. Fix-broken-
>
> Now what is at lp:~timo-jyrinki/lmms/1.0.0_packaging is good in the
> senses that a) it builds with bzr bd and PPA, b) orig tarball matches
> lp:lmms sources correctly, c) all the discussed patches should be
> included.
>
> I've also double-checked that the orig tarball / lp:lmms bzr2569 matches
> upstream master branch git commit
> 255b2a2f49c2c02
> with a couple of additional fixes. The Ubuntu packaging in turn adds two
> more fixes that were not in master at the time of bzr2569.
>
> The package is not lintian clean, but neither is the old package or the
> one in Debian, so I guess at this point it should be good enough.
>
> If testing is positive, please upload with:
> dget https:/
> + dput. The bzr branch lp:~timo-jyrinki/lmms/1.0.0_packaging suits too.
>