qmlapicheck should skip internal components
Bug #1256045 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Medium
|
Cris Dywan | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Some components are not technically part of the API and marked like this in qmldir:
internal TextCursor TextCursor.qml
qmlapicheck isn't aware of that file. It should probably read it and skip them.
Related branches
lp:~kalikiana/ubuntu-ui-toolkit/internalComponents
- Florian Boucault (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 665 lines (+249/-306)4 files modifiedcomponents.api (+216/-303)
modules/Ubuntu/Components/ListItems/qmldir (+0/-1)
tests/qmlapicheck.py (+32/-1)
tests/unit/add_qmlmakecheck.pri (+1/-1)
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Christian Dywan (kalikiana) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-ui-toolkit at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown