Toolbar hide timer needs to be disabled when interacting with the toolbar contents
Bug #1249031 reported by
Tim Peeters
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Medium
|
Tim Peeters | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The toolbar always closes after 5s of inactivity or when the user interacts with the app. This 5s timer is not paused when the user is interacting with contents of the toolbar, and it should be.
Currently we only have buttons in toolbars which take virtually no time to click, but when we have for example sliders or textfields, the user may spend time on them while the timer keeps running.
I propose to pause the timer when the user presses the toolbar, and to reset the timer on release after a press on the toolbar. For this, Panel needs to add signals for that which can be used in Toolbar to manipulate the timer.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/panel-hideTimer
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 305 lines (+104/-36)6 files modifiedCHANGES (+1/-0)
components.api (+1/-0)
modules/Ubuntu/Components/Panel.qml (+54/-6)
modules/Ubuntu/Components/Toolbar.qml (+1/-22)
tests/unit_x11/tst_components/tst_panel.qml (+33/-7)
tests/unit_x11/tst_components/tst_toolbar.qml (+14/-1)
Changed in ubuntu-ui-toolkit: | |
importance: | Undecided → Medium |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
hide timer must also be reset after app is resumed, for this bug: https:/ /bugs.launchpad .net/ubuntu- ui-toolkit/ +bug/1246790