The RequestFactory uses the pimpl pattern when it is not needed.
Bug #1251294 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The class is not going to be shared with other projects therefore the pimp is not needed.
Related branches
lp:~mandel/ubuntu-download-manager/remove-request-factory-pimpl
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 283 lines (+90/-129)2 files modifiedlibubuntudownloadmanager/system/request_factory.cpp (+77/-121)
libubuntudownloadmanager/system/request_factory.h (+13/-8)
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision None, scheduled for release in ubuntu- download- manager, milestone 0.3