SystemNetworkInfo uses pimpl pattern when it is not needed
Bug #1250946 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The SystemNetworkInfo is not used by any other project and therefore the pattern is not needed.
Related branches
lp:~mandel/ubuntu-download-manager/remove-network-info-pimpl
- PS Jenkins bot: Approve (continuous-integration)
- Diego Sarmentero (community): Approve
-
Diff: 408 lines (+149/-201)2 files modifiedlibubuntudownloadmanager/system/system_network_info.cpp (+133/-175)
libubuntudownloadmanager/system/system_network_info.h (+16/-26)
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 179, scheduled for release in ubuntu- download- manager, milestone 0.3