DBusConnection class uses the pimpl pattern when not needed
Bug #1251008 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The DBusConnection classes uses the pimpl pattern when it won't be exposed to other projects and therefore the pattern is not needed.
Related branches
lp:~mandel/ubuntu-download-manager/remove-dbusconn-pimpl
- PS Jenkins bot: Approve (continuous-integration)
- Diego Sarmentero (community): Approve
-
Diff: 116 lines (+10/-59)2 files modifiedlibubuntudownloadmanager/system/dbus_connection.cpp (+9/-56)
libubuntudownloadmanager/system/dbus_connection.h (+1/-3)
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 175, scheduled for release in ubuntu- download- manager, milestone 0.3