implicitly-generated variants are leaked
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bluetooth Menu |
Fix Released
|
Medium
|
Charles Kerr | ||
The Sound Menu |
Fix Released
|
Medium
|
Charles Kerr | ||
Vala |
Fix Released
|
Medium
|
|||
indicator-bluetooth (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
indicator-sound (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The implicitly-created GVariant is leaked in Service's volume_changed() function. We can fix it by making the variant explicit. But, should this be reported upstream as a Vala bug?
One line diff:
- volume_
+ volume_
C code generated from "volume_
static GVariant* _variant_new4 (gdouble value) {
return g_variant_ref_sink (g_variant_
}
static void indicator_
...
_tmp3_ = volume;
_tmp4_ = _variant_new4 (_tmp3_);
g_simple_
...
}
C code generated from "volume_
static void indicator_
...
_tmp3_ = volume;
_tmp4_ = g_variant_
g_variant_
_tmp5_ = _tmp4_;
g_simple_
_g_
...
}
Related branches
- Lars Karlitski (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 58 lines (+7/-7)1 file modifiedsrc/service.vala (+7/-7)
- Lars Karlitski (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 82 lines (+11/-11)2 files modifiedsrc/desktop.vala (+6/-6)
src/profile.vala (+5/-5)
Changed in indicator-sound: | |
importance: | Undecided → Medium |
summary: |
- GVariants leaked in service.vala's volume_changed() + implicitly-generated variants are leaked |
Changed in indicator-bluetooth: | |
importance: | Undecided → Medium |
Changed in indicator-sound: | |
status: | New → In Progress |
Changed in indicator-bluetooth: | |
status: | New → In Progress |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-sound: | |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in vala: | |
importance: | Unknown → Medium |
status: | Unknown → New |
Changed in vala: | |
status: | New → Fix Released |
Changed in indicator-sound: | |
status: | Fix Committed → Fix Released |
Changed in indicator-bluetooth: | |
status: | Fix Committed → Fix Released |
Fix committed into lp:indicator-bluetooth at revision 74, scheduled for release in indicator- bluetooth, milestone Unknown