| 2013-10-24 23:14:52 |
Charles Kerr |
bug |
|
|
added bug |
| 2013-10-24 23:15:05 |
Charles Kerr |
indicator-sound: importance |
Undecided |
Medium |
|
| 2013-10-24 23:18:24 |
Charles Kerr |
branch linked |
|
lp:~charlesk/indicator-sound/lp-1244468 |
|
| 2013-10-24 23:21:55 |
Charles Kerr |
description |
The implicitly-created GVariant is leaked in Service's volume_changed() function. We can fix it by making the variant explicit. But, should this be reported upstream as a Vala bug?
One line diff:
- volume_action.set_state (volume);
+ volume_action.set_state (new Variant.double (volume));
C code generated from "volume_action.set_state (volume)":
static GVariant* _variant_new4 (gdouble value) {
return g_variant_ref_sink (g_variant_new_double (value));
}
static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) {
...
_tmp3_ = volume;
_tmp4_ = _variant_new4 (_tmp3_);
g_simple_action_set_state (volume_action, _tmp4_);
...
}
C code generated from "volume_action.set_state (new Variant.double (volume))":
static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) {
...
_tmp3_ = volume;
_tmp4_ = g_variant_new_double (_tmp3_);
g_variant_ref_sink (_tmp4_);
_tmp5_ = _tmp4_;
...
_g_variant_unref0 (_tmp5_);
...
} |
The implicitly-created GVariant is leaked in Service's volume_changed() function. We can fix it by making the variant explicit. But, should this be reported upstream as a Vala bug?
One line diff:
- volume_action.set_state (volume);
+ volume_action.set_state (new Variant.double (volume));
C code generated from "volume_action.set_state (volume)":
static GVariant* _variant_new4 (gdouble value) {
return g_variant_ref_sink (g_variant_new_double (value));
}
static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) {
...
_tmp3_ = volume;
_tmp4_ = _variant_new4 (_tmp3_);
g_simple_action_set_state (volume_action, _tmp4_);
...
}
C code generated from "volume_action.set_state (new Variant.double (volume))":
static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) {
...
_tmp3_ = volume;
_tmp4_ = g_variant_new_double (_tmp3_);
g_variant_ref_sink (_tmp4_);
_tmp5_ = _tmp4_;
g_simple_action_set_state (volume_action, _tmp5_);
_g_variant_unref0 (_tmp5_);
...
} |
|
| 2013-10-24 23:24:04 |
Charles Kerr |
attachment added |
|
Valgrind log of described leak https://bugs.launchpad.net/indicator-sound/+bug/1244468/+attachment/3890421/+files/valgrind-vala-variant-leak.txt |
|
| 2013-10-25 00:18:09 |
Charles Kerr |
summary |
GVariants leaked in service.vala's volume_changed() |
implicitly-generated variants are leaked |
|
| 2013-10-25 00:18:36 |
Charles Kerr |
bug task added |
|
indicator-bluetooth |
|
| 2013-10-25 00:19:48 |
Launchpad Janitor |
branch linked |
|
lp:~charlesk/indicator-bluetooth/lp-1244468 |
|
| 2013-10-25 14:49:50 |
Charles Kerr |
indicator-bluetooth: importance |
Undecided |
Medium |
|
| 2013-10-25 14:49:53 |
Charles Kerr |
indicator-sound: status |
New |
In Progress |
|
| 2013-10-25 14:49:55 |
Charles Kerr |
indicator-bluetooth: status |
New |
In Progress |
|
| 2013-10-25 14:49:57 |
Charles Kerr |
indicator-bluetooth: assignee |
|
Charles Kerr (charlesk) |
|
| 2013-10-25 14:50:00 |
Charles Kerr |
indicator-sound: assignee |
|
Charles Kerr (charlesk) |
|
| 2013-10-25 14:57:52 |
Lars Karlitski |
bug watch added |
|
https://bugzilla.gnome.org/show_bug.cgi?id=710882 |
|
| 2013-10-25 14:57:52 |
Lars Karlitski |
bug task added |
|
vala |
|
| 2013-10-25 15:10:34 |
PS Jenkins bot |
indicator-bluetooth: status |
In Progress |
Fix Committed |
|
| 2013-10-25 15:17:14 |
PS Jenkins bot |
indicator-sound: status |
In Progress |
Fix Committed |
|
| 2013-10-25 15:34:14 |
Bug Watch Updater |
vala: status |
Unknown |
New |
|
| 2013-10-25 15:34:14 |
Bug Watch Updater |
vala: importance |
Unknown |
Medium |
|
| 2013-10-26 15:54:44 |
Bug Watch Updater |
vala: status |
New |
Fix Released |
|
| 2013-10-29 12:13:09 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-branches/ubuntu/trusty/indicator-bluetooth/trusty-proposed |
|
| 2013-10-29 12:20:48 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/trusty-proposed/indicator-sound |
|
| 2013-10-29 12:46:53 |
Launchpad Janitor |
indicator-bluetooth (Ubuntu): status |
New |
Fix Released |
|
| 2013-10-29 12:47:17 |
Launchpad Janitor |
indicator-sound (Ubuntu): status |
New |
Fix Released |
|
| 2014-03-03 13:58:46 |
Sebastien Bacher |
indicator-sound: status |
Fix Committed |
Fix Released |
|
| 2014-03-03 13:58:51 |
Sebastien Bacher |
indicator-bluetooth: status |
Fix Committed |
Fix Released |
|
