Quasselcore should use an Upstart script instead of a sysv initscript
Bug #1244036 reported by
Michael Marley
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
quassel (Ubuntu) |
Fix Released
|
Wishlist
|
Michael Marley |
Bug Description
I have written an Upstart script to replace the old sysv initscript for the quassel core.
Changed in quassel (Ubuntu): | |
status: | Incomplete → In Progress |
assignee: | nobody → Michael Marley (thefirstm) |
Changed in quassel (Ubuntu): | |
importance: | Undecided → Wishlist |
To post a comment you must log in.
Looks pretty good, but I got a few comments from a developer that knows way more about upstart than me:
<stgraber> ScottK: looks to me like he wants "start on filesystem and static-network-up" instead, but the start on condition he's using isn' wrong either. Just because I'm picky, the respawn stanza is usually put before the script section so it's easier to spot.
<stgraber> besides that, it should all work fine assuming quasselcore doesn't fork/daemonize
<stgraber> oh and hardcoding /usr/bin is usually not considered a good thing
<ScottK> So just excec quasselcore?
<ScottK> exec even
<ScottK> stgraber: ^^^
<stgraber> yep
<ScottK> Thanks.