Non i18n/Ambigous string

Bug #1233214 reported by Yaron
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Translations
Fix Released
Low
Unassigned
ubuntu-system-settings
Fix Released
Low
Iain Lane
ubuntu-system-settings (Ubuntu)
Fix Released
Low
Unassigned
Tags: i18n
Yaron (sh-yaron)
tags: added: i18n
Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1233214] [NEW] Non i18n/Ambigous string

Hi,

Thanks for this feedback - it's useful.

On Mon, Sep 30, 2013 at 02:56:27PM -0000, Yaron wrote:
> Public bug reported:
>
> Non i18n strings (Could be both feminine and masculine, confusing in Hebrew):
> https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/156/+translate
> https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/159/+translate

These were just to prevent warnings and can't actually be displayed.
Therefore they don't need to be translated at all. I'll just make them
unstranslated blank strings.

>
> Untranslatable due to lack of percentage sign:
> https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/181/+translate

It's a variable, not a literal percentage sign. I added a comment to
this and other similar cases.

>
> Cannot understand context (Please add a comment to explain what this is about):
> https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/189/+translate
> https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/190/+translate

Done.

https://code.launchpad.net/~laney/ubuntu-system-settings/translation-tweaks/+merge/188374

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Yaron (sh-yaron) wrote :

Hey Iain!
Thanks for the quick response,

The problem with the string with the percentage sign is not the percentage but the fact that I get this error no matter how I try to translate it:
a format specification for argument 1 doesn't exist in 'msgstr[0]'

I think that the problem is with Launchpad and it's plural form consistency that doesn't allow it to add freaky forms like this one.

Please check it as well (Try to translate to Hebrew, don't worry, I have the location of the strings, I'll just change it later after you'll succeed).

Thanks!

Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1233214] Re: Non i18n/Ambigous string

On Mon, Sep 30, 2013 at 04:09:02PM -0000, Yaron wrote:
> Hey Iain!
> Thanks for the quick response,
>
> The problem with the string with the percentage sign is not the percentage but the fact that I get this error no matter how I try to translate it:
> a format specification for argument 1 doesn't exist in 'msgstr[0]'

I (think that I) got it, thanks:

https://bazaar.launchpad.net/~laney/ubuntu-system-settings/translation-tweaks/revision/410

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
David Planella (dpm) wrote :

Thanks a lot for the translation fixes!

Looking at [1] and s discussed on IRC, I believe this:

i18n.tr("%1 minute", "%1 minutes".arg(5), 5)

should be fixed to read:

i18n.tr("%1 minute", "%1 minutes", 5).arg(5)

Otherwise, if I read it correctly, we're only passing the argument to the second string (even if it's a >1 constant and we'll never hit the string for singular.

[1] https://bazaar.launchpad.net/~laney/ubuntu-system-settings/translation-tweaks/revision/410

Changed in ubuntu-system-settings:
assignee: nobody → Iain Lane (laney)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Yaron (sh-yaron) wrote :

Hey again!
There's one last thing…
https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/157/+translate

Not sure what's incorrect, is this string valid or needs to be removed?

Thank you very much, you did a terrific job!

Revision history for this message
Iain Lane (laney) wrote :

On Mon, Sep 30, 2013 at 08:30:15PM -0000, David Planella wrote:
> Thanks a lot for the translation fixes!
>
> Looking at [1] and s discussed on IRC, I believe this:
>
> i18n.tr("%1 minute", "%1 minutes".arg(5), 5)
>
> should be fixed to read:
>
> i18n.tr("%1 minute", "%1 minutes", 5).arg(5)
>
> Otherwise, if I read it correctly, we're only passing the argument to
> the second string (even if it's a >1 constant and we'll never hit the
> string for singular.

Are you saying that I missed a place? I don't see it. The branch is
merged into trunk—please check that out and look there.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Iain Lane (laney) wrote :

On Mon, Sep 30, 2013 at 08:54:34PM -0000, Yaron wrote:
> Hey again!
> There's one last thing…
> https://translations.launchpad.net/ubuntu-system-settings/trunk/+pots/ubuntu-system-settings/he/157/+translate
>
> Not sure what's incorrect, is this string valid or needs to be removed?

https://code.launchpad.net/~laney/ubuntu-system-settings/one-more-translation-fix/+merge/188463

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Yaron (sh-yaron) wrote :

As far as I'm concerned, that's it, Hebrew is now complete, thank you very much!

Changed in ubuntu-system-settings:
status: In Progress → Fix Committed
Changed in ubuntu-system-settings (Ubuntu):
status: New → Fix Committed
importance: Undecided → Low
Changed in ubuntu-translations:
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.1+13.10.20131002-0ubuntu1

---------------
ubuntu-system-settings (0.1+13.10.20131002-0ubuntu1) saucy; urgency=low

  [ Sebastien Bacher ]
  * click: the installed-size info is in kib, not in bytes.

  [ Iain Lane ]
  * Use the indicator's value for the charge level instead of
    calculating it from QtSystems derived information.
  * [battery] Update the UI dynamically when the wireless state changes.
  * Various translation tweaks as noted in LP: #1233214. (LP: #1215712,
    #1233214)
  * [battery] Bind the onClicked handlers instead of checked to avoid
    loops when enabling/disabling wifi.
  * Remove one more missed translation.
  * Bump required version of ubuntu-keyboard-data, as we require the
    schemas for the language panel.
  * Remove the SettingsCheckEntry now that the design issues are
    resolved.

  [ Ted Gould ]
  * Adding a %u to the desktop file Exec line.

  [ William Hua ]
  * Hook up language panel to some maliit settings.

  [ Didier Roche ]
  * Use some async calls for system update where we don't expect any
    returned value.
  * Add an indeterminate progress bar until system image answers.

  [ Charles Kerr ]
  * Show an ActivityIndicator to tell users when discovery mode is on to
    search for new bluetooth devices.
  * add PIN code pairing. Implementation is similar to the existing
    passkey pairing.

  [ Ken VanDine ]
  * revert the previous revert done in rev 391, Bug (#LP: #1231368) was
    caused by gallery-app needing a rebuild for content-hub changes. .
    (LP: #1231368)

  [ Alberto Mardegan ]
  * Parse URLs given in command line. (LP: #1227690)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 419
 -- Ubuntu daily release <email address hidden> Wed, 02 Oct 2013 04:09:15 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: Fix Committed → Fix Released
Changed in ubuntu-system-settings:
status: Fix Committed → Fix Released
Changed in ubuntu-translations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.