Database migration can incorrectly drop owner column on downgrade

Bug #1204941 reported by Johannes Erdfelt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Johannes Erdfelt

Bug Description

While fixing bug 1204940, I found that migration 009 can incorrectly drop the owner column during downgrade. This appears to only happen with sqlite and is because the get_images_table() doesn't have the correct schema, missing the owner column.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/38644

Changed in glance:
assignee: nobody → Johannes Erdfelt (johannes.erdfelt)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/38644
Committed: http://github.com/openstack/glance/commit/773b720b513130468ed615a968103c922d817577
Submitter: Jenkins
Branch: master

commit 773b720b513130468ed615a968103c922d817577
Author: Johannes Erdfelt <email address hidden>
Date: Thu Jul 25 02:18:49 2013 +0000

    Make sure owner column doesn't get dropped during downgrade

    Fixes bug 1204941

    The owner column was missing from the table schema. Because of limitations
    of sqlite and implementation details in SQLAlchemy-migrate, this would end
    up dropping the owner column during a downgrade when using sqlite.

    Change-Id: If8f7f16c9b6fb059f0fcfdf8967afd37f19864b6

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.