Database migration snake walk test doesn't actually snake walk

[Johannes Erdfelt]

The test is intended to upgrade to a database version, downgrade to the previous version, then upgrade again. The test should ensure that the upgrade and downgrade paths work correctly.

However, the downgrade part specifies the same version as the initial upgrade, which is effectively a noop. The last upgrade is also effectively a noop because the database is already on that schema version.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/38645

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/38645
Committed: http://github.com/openstack/glance/commit/d53985641a3db8b84772158259dadee7bbf5e067
Submitter: Jenkins
Branch: master

commit d53985641a3db8b84772158259dadee7bbf5e067
Author: Johannes Erdfelt <email address hidden>
Date: Thu Jul 25 02:21:03 2013 +0000

    Perform database migration snake walk test correctly

    Fixes bug 1204940

    The database migration snake walk test would not properly perform downgrades
    leaving that part of the test non-functional.

    Also, if downgrade was True, the test wouldn't downgrade all of the way to
    the first migration because of a fence post error.

    Change-Id: I44873fc9bb0b159c941a90ce19b74e1afba8b6a8