source file listing shows icons but does not render them well

[Nick Veitch]

In the new source view, if you select the icon file, it just gets listed. Actually, I always get a load of lines, sometimes with bits of symbols on them. It would be nice to recognise the .svg type and display the icon I guess.

[Richard Harding (rharding)]

Thanks Nick. It took me a minute to parse this as we just recently changed the tab name to "Source".

We can either try to detect the content-type and adjust how we display the content. The other way to go is to remove non-text content from the list of files we show in the drop down. I'm not sure which way people think would make the most sense.

[Nick Veitch (evilnick)]

I think if you are going to say it is a view of the source then it should
at least list all the files.
It isn't really necessary to dispaly the icon (after all, it should already
be on the page), but it would be okay to say "This is not a text file" or
similar for all the things which don't make sense to list.

On Mon, Jul 22, 2013 at 1:20 PM, Richard Harding <<email address hidden>
> wrote:

> Thanks Nick. It took me a minute to parse this as we just recently
> changed the tab name to "Source".
>
> We can either try to detect the content-type and adjust how we display
> the content. The other way to go is to remove non-text content from the
> list of files we show in the drop down. I'm not sure which way people
> think would make the most sense.
>
> ** Changed in: juju-gui
> Importance: Undecided => Medium
>
> ** Changed in: juju-gui
> Status: New => Triaged
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1203583
>
> Title:
> source view of icon files is weird
>
> Status in Juju Graphical Interface:
> Triaged
>
> Bug description:
> Not terribly important, but in the new source view, if you select the
> icon file, it just gets listed. Actually, I always get a load of
> lines, sometimes with bits of symbols on them. It would be nice to
> recognise the .svg type and display the icon I guess.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-gui/+bug/1203583/+subscriptions
>

[Nick Veitch (evilnick)]

ALSO! On a similar topic, can we please please please SORT the list of files alphabetically? Try finding the file you want in something like mysql for instance...

[Gary Poster (gary)]

Comment 3 is represented by bug 1217545.

[Nick Veitch (evilnick)]

\o/
On Oct 9, 2013 2:35 PM, "Gary Poster" <email address hidden> wrote:

> ** Changed in: juju-gui
> Status: Triaged => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1203583
>
> Title:
> source file listing shows icons but does not render them well
>
> Status in Juju Graphical Interface:
> Fix Committed
>
> Bug description:
> In the new source view, if you select the icon file, it just gets
> listed. Actually, I always get a load of lines, sometimes with bits of
> symbols on them. It would be nice to recognise the .svg type and
> display the icon I guess.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-gui/+bug/1203583/+subscriptions
>