code logical error exists in vmwareapi vif.py
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Yaguang Tang | ||
Grizzly |
Fix Released
|
High
|
Yaguang Tang |
Bug Description
nova/virt/
60 if network_ref is None:
61 # Create a port group on the vSwitch associated with the
62 # vlan_interface corresponding physical network adapter on the ESX
63 # host.
64 network_
65 vswitch_associated, vlan_num,
66 cluster)
67 else:
68 # Get the vlan id and vswitch corresponding to the port group
69 _get_pg_info = network_
70 pg_vlanid, pg_vswitch = _get_pg_
71
72 # Check if the vswitch associated is proper
73 if pg_vswitch != vswitch_associated:
74 raise exception.
75 bridge=bridge, expected=
76 actual=pg_vswitch)
77
the check for pg_vlanid, pg_vswitch logic code have wrong indent , cause a referenced before assignment error.
Changed in nova: | |
assignee: | nobody → Yaguang Tang (heut2008) |
status: | New → In Progress |
tags: | added: vmware |
Changed in nova: | |
importance: | Undecided → High |
Changed in nova: | |
milestone: | none → havana-1 |
status: | Fix Committed → Fix Released |
tags: | removed: in-stable-grizzly |
Changed in nova: | |
milestone: | havana-1 → 2013.2 |
Reviewed: https:/ /review. openstack. org/28277 github. com/openstack/ nova/commit/ b7f994076961861 6d37267a50afe49 5bb8608d27
Committed: http://
Submitter: Jenkins
Branch: master
commit b7f994076961861 6d37267a50afe49 5bb8608d27
Author: Yaguang Tang <email address hidden>
Date: Mon May 6 15:54:54 2013 +0800
Add unitests for VMware vif, and fix code logical error.
Fix code logical error that cause variable referenced before assignment.
Add unittests for vmwareapi vif.
Fix bug #1177635
Change-Id: I6656e8b7741706 1eca2a56d50820f 5385c0ae987