unity-tweak-tool crashed with TypeError in function(): get_rgba() takes exactly 1 argument (2 given)

[Aaron K. Henderson]

SRU Justification:

[Impact]

 * This is currently the number 12 crasher for raring in the past month on errors.ubuntu.com

[Test Case]

 1) With version 0.0.4 from raring installed, attempt to set the launcher to a custom color. This will result in this crash.
 2) Install 0.0.4ubuntu0.1 from raring-proposed and verify that this does not occur.

[Regression Potential]

 * A change in gir1.2-gtk-3.0 led to this issue. The fix uses a try/except, falling back to the old behavior for older versions of gir1.2-gtk-3.0. There is very little chance of regression.

[Other Info]

 As this is a native package, the patches are applied directly. The fix is taken from this upstream commit:

https://github.com/freyja-dev/unity-tweak-tool/commit/b48745a39348dd1eab10cb9af9d798efe3361b8e

---------

Clean Ubuntu 12.10 install. Installed Unity Tweak Tool, crashes everytime I start it.

ProblemType: Crash
DistroRelease: Ubuntu 12.10
Package: unity-tweak-tool 0.0.4-0~114~quantal1 [origin: LP-PPA-freyja-dev-unity-tweak-tool-daily]
ProcVersionSignature: Ubuntu 3.5.0-26.42-generic 3.5.7.6
Uname: Linux 3.5.0-26-generic x86_64
NonfreeKernelModules: nvidia wl
ApportVersion: 2.6.1-0ubuntu10
Architecture: amd64
CrashDB: {"impl": "launchpad", "project": "unity-tweak-tool"}
Date: Sat Apr 6 22:25:09 2013
ExecutablePath: /usr/bin/unity-tweak-tool
InstallationDate: Installed on 2013-04-06 (0 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.5)
InterpreterPath: /usr/bin/python3.2mu
MarkForUpload: True
PackageArchitecture: all
ProcCmdline: /usr/bin/python3 /usr/bin/unity-tweak-tool
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
PythonArgs: ['/usr/bin/unity-tweak-tool']
SourcePackage: unity-tweak-tool
Title: unity-tweak-tool crashed with TypeError in function(): get_rgba() takes exactly 1 argument (2 given)
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

[J Phani Mahesh (phanimahesh)]

This bug is caused by an update to gir1.2-gtk-3.0 package. This will be fixed in a couple of days.

Thanks for bringing it to our notice. :)

[J Phani Mahesh (phanimahesh)]

Raring repo has an updated version (3.6.4-0ubuntu6) that might have changed the function get_rgba() to be more correct.
( Requiring two arguments upto atleast version 3.6.0-0ubuntu3.2 was a "bug", and we had to play along. )

For those on quantal experiencing this bug, it is because you enabled a third-party PPA that upgraded the package.
Last I checked, quantal-updates still has 3.6.0-0ubuntu3.2.

[fossfreedom (fossfreedom)]

hmmm not a nice bug ....

maybe a try - except call would be better to catch the two variations. Probably particularly important since ubuntu users have a habit of using PPAs that may also inadvertently "upgrade" (or "downgrade" depending upon your POV) this particular GI library.

[J Phani Mahesh (phanimahesh)]

The fix should land in the PPA soon. It will be in the official raring repo when we request for the next sync from upstream. Can take few weeks.

@fossfreedom: After debating whether to maintain different source or to go with try except, we voted on the try-except approach. Just the version number of installed package was not really reliable enough. As you said. :)

[Andrew Starr-Bochicchio (andrewsomething)]

Upstream commit:

https://github.com/freyja-dev/unity-tweak-tool/commit/b48745a39348dd1eab10cb9af9d798efe3361b8e

Opening a raring task as this is currently the number 12 crasher for the past month on errors.ubuntu.com

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-tweak-tool - 0.0.4ubuntu1

---------------
unity-tweak-tool (0.0.4ubuntu1) saucy; urgency=low

  * Backport fixes from upstream git.
  * UnityTweakTool/elements/colorchooser.py
   - Fix TypeError in get_rgba() (LP: #1165627)
  * UnityTweakTool/section/sphagetti/compiz.py
   - Fix TypeError in color_to_hash() (LP: #1166884)
  * UnityTweakTool/section/unity.py
   - Fix Show recently used and more suggestions in dash search (LP: #1166294)
 -- Andrew Starr-Bochicchio <email address hidden> Mon, 13 May 2013 16:39:04 -0400

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-tweak-tool - 0.0.4ubuntu0.1

---------------
unity-tweak-tool (0.0.4ubuntu0.1) raring-updates; urgency=low

  * Backport fixes from upstream git.
  * UnityTweakTool/elements/colorchooser.py
   - Fix TypeError in get_rgba() (LP: #1165627)
  * UnityTweakTool/section/sphagetti/compiz.py
   - Fix TypeError in color_to_hash() (LP: #1166884)
  * UnityTweakTool/section/unity.py
   - Fix Show recently used and more suggestions in dash search (LP: #1166294)
 -- Andrew Starr-Bochicchio <email address hidden> Mon, 13 May 2013 16:39:04 -0400

[Adam Conrad (adconrad)]

Hello Aaron, or anyone else affected,

Accepted unity-tweak-tool into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity-tweak-tool/0.0.4ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Adam Conrad (adconrad)]

Ignore the above message about this being "Fix Released" in raring-updates. This was due to the uploader mistargetting the upload to -updates instead of -proposed, and I have since copied it back to -proposed and it will be deleted from -updates. Please verify this SRU as usual, and we can migrate it once it's been checked.

[Barneedhar (barneedhar)]

Confirming package version 0.0.4ubuntu0.1 contains the fix for this bug.

[Brian Murray (brian-murray)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-tweak-tool - 0.0.4ubuntu0.1

---------------
unity-tweak-tool (0.0.4ubuntu0.1) raring-updates; urgency=low

  * Backport fixes from upstream git.
  * UnityTweakTool/elements/colorchooser.py
   - Fix TypeError in get_rgba() (LP: #1165627)
  * UnityTweakTool/section/sphagetti/compiz.py
   - Fix TypeError in color_to_hash() (LP: #1166884)
  * UnityTweakTool/section/unity.py
   - Fix Show recently used and more suggestions in dash search (LP: #1166294)
 -- Andrew Starr-Bochicchio <email address hidden> Mon, 13 May 2013 16:39:04 -0400