Ubuntu
wvdial package

wvdial deletes link to /etc/resolvconf/run/resolv.conf and writes a permanent /etc/resolv.conf

Bug #11626 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
wvdial (Debian)
Fix Released
Unknown
wvdial (Ubuntu)
Invalid
High
Unassigned

Bug Description

Automatically imported from Debian bug report #288481 http://bugs.debian.org/288481

See original description
Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #288481 http://bugs.debian.org/288481

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 4 Jan 2005 00:47:26 +0100 (MET)
From: "Malte Schmidt-Tychsen" <email address hidden>
To: <email address hidden>
Subject: wvdial deletes link to /etc/resolvconf/run/resolv.conf and writes a permanent
 /etc/resolv.conf

Package: wvdial
Version: 1.54.0-1
Severity: serious

Hi there,

I played around a bit with my network connections. I have a pcmcia nic
connected to my home network with dhcp running on my fileserver. I used
webmin-wvdial to connect to the internet via a mobile phone via irda. I am
not sure when, but I removed the nic (which is managed by ifplugd, a debian
package to manage mobile nics) somewhere in the process to see if the
connection was really made over the mobile.

After I was done playing around I reinserted the nic and internet access
didn't come back automagically. So I did the ifup eth0 and got an error
message telling me that /etc/resolv.conf was no longer linked to
/etc/resolvconf/run/resolv.conf. /etc/resolv.conf contained the dns servers
supplied by the server I connected to via wvdial, while
/etc/resolvconf/run/resolv.conf cotained the addresses of the dns servers
supplied by my dhcp.

I have to admit that I really stress tested the thing probabley removing and
reinserting the nic, which always drives ifplugd crazy, but under no
circumstances should wvdial ever delete the symbolic link and put up its own
/etc/resolv.conf. I am still not sure what or when it happened, so ifplugd
could still be the culprit, but the dns servers from wvdial were in
/etc/resolv.conf, which suggests that it was wvdial.

I am sorry that I can't provde further details at the moment, but since this
is such a severe bug (breaks all net access) I thought I should respond
ASAP.

Thanks,

Malte Schmidt-Tychsen

--
+++ GMX - die erste Adresse f�l, Message, More +++
1 GB Mailbox bereits in GMX FreeMail http://www.gmx.net/de/go/mail

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : A bug, but not in wvdial, it seems

If a program removes the symlink at /etc/resolv.conf then that is
certainly a bug in the program.

Looking at the wvdial source code, however, I can't see anything that
could do this.

--
Thomas Hood <email address hidden>

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1104904472.10099.46.camel@thanatos>
Date: Wed, 05 Jan 2005 06:54:32 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: A bug, but not in wvdial, it seems

If a program removes the symlink at /etc/resolv.conf then that is
certainly a bug in the program.

Looking at the wvdial source code, however, I can't see anything that
could do this.

--
Thomas Hood <email address hidden>

Revision history for this message
In , Malte Schmidt-Tychsen (msty) wrote : if there is nothing, you might as well close it

Hi Thomas,

maybe I will try to reproduce it today. I used webmin-wvdial and the bug
could be located anywhere. webmin-wvdial, wvdial, ppp-tools, ifplugd ...

Even if I can reproduce it come to think of it I don't know how I would find
out what package caused this. Is there a tool that can check what programs
change/changed a file over a period of time and what was done?

For the curious I attached an output of dpkg -l, so anyone can take a wild
guess at what might have caused this. The result was there, though, I can
assure you of this.

So there was a policy violation that at least involved wvdial, since the
dialup dns servers were in that file that is not really supposed to exist.

Thx for looking at the code.

Malte

> If a program removes the symlink at /etc/resolv.conf then that is
> certainly a bug in the program.
>
> Looking at the wvdial source code, however, I can't see anything that
> could do this.
>
> --
> Thomas Hood <email address hidden>
>
>

--
________________________________
Malte Schmidt-Tychsen
Backbergstr. 4H
12359 Berlin

Tel.: +49 (0) 30 / 606 9454
--------------------------------
() ASCII Ribbon Campaign - against HTML email
/\

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote :

reassign 288481 webmin-wvdial
thanks

On Wed, 2005-01-05 at 11:56 +0100, Malte Schmidt-Tychsen wrote:
> maybe I will try to reproduce it today. I used webmin-wvdial and the bug
> could be located anywhere. webmin-wvdial, wvdial, ppp-tools, ifplugd ...

I have found the culprit: webmin-wvdial. The evil code is
in /usr/share/webmin/wvdial/ppp-client-lib.pl:

    $resolv_conf = "/etc/resolv.conf";
    $ppp_resolv_conf = "/etc/ppp/resolv.conf";
    $save_resolv_conf = $resolv_conf.".save";
    [...]
    if ($connected && $autodns) {
        # If the resolv.conf file has not been modified, and the PPP
        # resolv.conf has, copy it into place
    [...]
                        # A PPP DNS config has been created .. use it
                        &system_logged("cp $resolv_conf $save_resolv_conf")
                                if (!-l $resolv_conf);
                        unlink($resolv_conf);
                        &system_logged("cp $ppp_resolv_conf $resolv_conf");
    [...]
    sub ppp_disconnect
    {
    [...]
            # Restore the saved DNS config file, if it hasn't been done
    [...]
            if (!-l $resolv_conf && $ost[9] < time()-5 && -r $save_resolv_conf) {
                &system_logged("mv $save_resolv_conf $resolv_conf");
                if ($_[1] == 0) {
                        print "$text{'disc_dns'}<p>\n";
                        }
                elsif ($_[1] == 1) {
                        print "$text{'disc_dns'}\n\n";
                        }
                }
                &system_logged("rm -f $ppp_resolv_conf");
                return 1;
            }
    [...]
    }

I don't know why webmin-wvdial tries to do this. If the user
wants /etc/resolv.conf to be a copy of /etc/ppp/resolv.conf then she can
simply make the former a symlink to the latter.

More relevant to you and me, this code isn't compatible with resolvconf
which requires that /etc/resolv.conf remain a symlink
to /etc/resolvconf/run/resolv.conf.

Furthermore, the code is buggy. If /etc/resolv.conf is originally a
symlink then it won't be restored as a symlink. If /etc/ppp/resolv.conf
is originally a symlink then this code will delete it.

This whole "feature" should be commented out.

--
Thomas Hood <email address hidden>

Revision history for this message
In , Thomas Hood (jdthood-yahoo) wrote : retitle 288481 to webmin-wvdial deletes symlink at /etc/resolv.conf

# Automatically generated email from bts, devscripts version 2.8.5
retitle 288481 webmin-wvdial deletes symlink at /etc/resolv.conf

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1104935322.10099.88.camel@thanatos>
Date: Wed, 05 Jan 2005 15:28:42 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Cc: <email address hidden>
Subject: Re: if there is nothing, you might as well close it

reassign 288481 webmin-wvdial
thanks

On Wed, 2005-01-05 at 11:56 +0100, Malte Schmidt-Tychsen wrote:
> maybe I will try to reproduce it today. I used webmin-wvdial and the bug
> could be located anywhere. webmin-wvdial, wvdial, ppp-tools, ifplugd ...

I have found the culprit: webmin-wvdial. The evil code is
in /usr/share/webmin/wvdial/ppp-client-lib.pl:

    $resolv_conf = "/etc/resolv.conf";
    $ppp_resolv_conf = "/etc/ppp/resolv.conf";
    $save_resolv_conf = $resolv_conf.".save";
    [...]
    if ($connected && $autodns) {
        # If the resolv.conf file has not been modified, and the PPP
        # resolv.conf has, copy it into place
    [...]
                        # A PPP DNS config has been created .. use it
                        &system_logged("cp $resolv_conf $save_resolv_conf")
                                if (!-l $resolv_conf);
                        unlink($resolv_conf);
                        &system_logged("cp $ppp_resolv_conf $resolv_conf");
    [...]
    sub ppp_disconnect
    {
    [...]
            # Restore the saved DNS config file, if it hasn't been done
    [...]
            if (!-l $resolv_conf && $ost[9] < time()-5 && -r $save_resolv_conf) {
                &system_logged("mv $save_resolv_conf $resolv_conf");
                if ($_[1] == 0) {
                        print "$text{'disc_dns'}<p>\n";
                        }
                elsif ($_[1] == 1) {
                        print "$text{'disc_dns'}\n\n";
                        }
                }
                &system_logged("rm -f $ppp_resolv_conf");
                return 1;
            }
    [...]
    }

I don't know why webmin-wvdial tries to do this. If the user
wants /etc/resolv.conf to be a copy of /etc/ppp/resolv.conf then she can
simply make the former a symlink to the latter.

More relevant to you and me, this code isn't compatible with resolvconf
which requires that /etc/resolv.conf remain a symlink
to /etc/resolvconf/run/resolv.conf.

Furthermore, the code is buggy. If /etc/resolv.conf is originally a
symlink then it won't be restored as a symlink. If /etc/ppp/resolv.conf
is originally a symlink then this code will delete it.

This whole "feature" should be commented out.

--
Thomas Hood <email address hidden>

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <20050105143651.9D31810D69F@localhost>
Date: Wed, 5 Jan 2005 15:36:51 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: retitle 288481 to webmin-wvdial deletes symlink at /etc/resolv.conf

# Automatically generated email from bts, devscripts version 2.8.5
retitle 288481 webmin-wvdial deletes symlink at /etc/resolv.conf

Revision history for this message
Matt Zimmerman (mdz) wrote :

webmin-wvdial is in universe

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : New release of resolvconf pending

I will soon release a new version of resolvconf that Conflicts with
webmin-wvdial. If the webmin-wvdial bug is ever fixed then I'll version
the Conflict.
--
Thomas Hood <email address hidden>

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1105139405.6928.66.camel@thanatos>
Date: Sat, 08 Jan 2005 00:10:05 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: New release of resolvconf pending

I will soon release a new version of resolvconf that Conflicts with
webmin-wvdial. If the webmin-wvdial bug is ever fixed then I'll version
the Conflict.
--
Thomas Hood <email address hidden>

Revision history for this message
In , Frank Lichtenheld (djpig) wrote : Re: Bug#288481: if there is nothing, you might as well close it

On Wed, Jan 05, 2005 at 03:28:42PM +0100, Thomas Hood wrote:
> I have found the culprit: webmin-wvdial. The evil code is
> in /usr/share/webmin/wvdial/ppp-client-lib.pl:
 [...]
> I don't know why webmin-wvdial tries to do this. If the user
> wants /etc/resolv.conf to be a copy of /etc/ppp/resolv.conf then she can
> simply make the former a symlink to the latter.
>
> More relevant to you and me, this code isn't compatible with resolvconf
> which requires that /etc/resolv.conf remain a symlink
> to /etc/resolvconf/run/resolv.conf.
>
> Furthermore, the code is buggy. If /etc/resolv.conf is originally a
> symlink then it won't be restored as a symlink. If /etc/ppp/resolv.conf
> is originally a symlink then this code will delete it.
>
> This whole "feature" should be commented out.

I'm currently preparing a QA upload for the orphaned webmin-optional
package. Could you please take a look at the attached patch andtell
if you would consider it sufficient? I tried to take a less invasive
approach than completly removing the code since I don't want to
introduce too great change in behaviour in a QA upload.

Gruesse,
--
Frank Lichtenheld <email address hidden>
www: http://www.djpig.de/

Revision history for this message
In , Frank Lichtenheld (djpig) wrote : tagging 288481

# Automatically generated email from bts, devscripts version 2.8.5
tags 288481 patch

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Sat, 8 Jan 2005 15:01:58 +0100
From: Frank Lichtenheld <email address hidden>
To: <email address hidden>
Subject: tagging 288481

# Automatically generated email from bts, devscripts version 2.8.5
tags 288481 patch

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (4.7 KiB)

Message-ID: <email address hidden>
Date: Sat, 8 Jan 2005 14:59:45 +0100
From: Frank Lichtenheld <email address hidden>
To: Thomas Hood <email address hidden>, <email address hidden>
Subject: Re: Bug#288481: if there is nothing, you might as well close it

--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 05, 2005 at 03:28:42PM +0100, Thomas Hood wrote:
> I have found the culprit: webmin-wvdial. The evil code is
> in /usr/share/webmin/wvdial/ppp-client-lib.pl:
 [...]
> I don't know why webmin-wvdial tries to do this. If the user
> wants /etc/resolv.conf to be a copy of /etc/ppp/resolv.conf then she can
> simply make the former a symlink to the latter.
>
> More relevant to you and me, this code isn't compatible with resolvconf
> which requires that /etc/resolv.conf remain a symlink
> to /etc/resolvconf/run/resolv.conf.
>
> Furthermore, the code is buggy. If /etc/resolv.conf is originally a
> symlink then it won't be restored as a symlink. If /etc/ppp/resolv.conf
> is originally a symlink then this code will delete it.
>
> This whole "feature" should be commented out.

I'm currently preparing a QA upload for the orphaned webmin-optional
package. Could you please take a look at the attached patch andtell
if you would consider it sufficient? I tried to take a less invasive
approach than completly removing the code since I don't want to
introduce too great change in behaviour in a QA upload.

Gruesse,
--
Frank Lichtenheld <email address hidden>
www: http://www.djpig.de/

--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="webmin-optional.288481.patch"

diff -Naur webmin-optional-1.160.bak/debian/changelog webmin-optional-1.160/debian/changelog
--- webmin-optional-1.160.bak/debian/changelog 2005-01-08 14:08:32.000000000 +0100
+++ webmin-optional-1.160/debian/changelog 2005-01-08 14:59:35.000000000 +0100
@@ -1,3 +1,19 @@
+webmin-optional (1.160-3) unstable; urgency=medium
+
+ * QA Upload
+ * webmin-wvdial: don't attempt to overwrite resolv.conf if it
+ is a symlink since this could break in many situations
+ (like when using resolvconf) (Closes: #288481) Also don't
+ attempt to delete the ppp specific resolv.conf, this isn't
+ our business. Pointed out by Thomas Hood.
+ * webmin-dhcpd: change dhcp-server to dhcp3-server in depends,
+ the former isn't available anymore (Closes: #260608)
+ * webmin-mysql: allow virtual-mysql-client as an alternative
+ to mysql-client as dependency. This allows to use mysql-client-4.1.
+ (Closes: #287128)
+
+ -- Frank Lichtenheld <email address hidden> Sat, 8 Jan 2005 14:47:01 +0100
+
 webmin-optional (1.160-2) unstable; urgency=high

   * I'm not here. This isn't happening.
diff -Naur webmin-optional-1.160.bak/debian/control webmin-optional-1.160/debian/control
--- webmin-optional-1.160.bak/debian/control 2005-01-08 14:08:32.000000000 +0100
+++ webmin-optional-1.160/debian/control 2005-01-08 14:30:03.000000000 +0100
@@ -49,7 +49,7 @@
 Package: webmin-dhcpd
 Architecture: all
 Priority: optional
-Depends: webmin (>= 1.140), ${perl:Depends}, dhcp | dhcp-server
+Depends: webmin...

Read more...

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : Re: Bug#288481: if there is nothing, you might as well close it

On Sat, 2005-01-08 at 14:59 +0100, Frank Lichtenheld wrote:
> I'm currently preparing a QA upload for the orphaned webmin-optional
> package. Could you please take a look at the attached patch andtell
> if you would consider it sufficient? I tried to take a less invasive
> approach than completly removing the code since I don't want to
> introduce too great change in behaviour in a QA upload.

The patch looks OK. My only comment would be that you might want to put
the "-l $resolv_conf" test up higher since there may be no point to
executing the sleep(3), etc., if resolv.conf is not going to be updated
later anyway. E.g.,

- # If the resolv.conf file has not been modified, and the PPP
- # resolv.conf has, copy it into place
- while(1) {
+ # If the resolv.conf file has not been modified and is not
+ # a symlink, and the pppd-generated resolv.conf file has
+ # been modified, then copy the latter over the former
+ if (!-l $resolv_conf) while (1)

I haven't tested this.
--
Thomas Hood <email address hidden>

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1105199784.8723.17.camel@thanatos>
Date: Sat, 08 Jan 2005 16:56:24 +0100
From: Thomas Hood <email address hidden>
To: Frank Lichtenheld <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#288481: if there is nothing, you might as well close it

On Sat, 2005-01-08 at 14:59 +0100, Frank Lichtenheld wrote:
> I'm currently preparing a QA upload for the orphaned webmin-optional
> package. Could you please take a look at the attached patch andtell
> if you would consider it sufficient? I tried to take a less invasive
> approach than completly removing the code since I don't want to
> introduce too great change in behaviour in a QA upload.

The patch looks OK. My only comment would be that you might want to put
the "-l $resolv_conf" test up higher since there may be no point to
executing the sleep(3), etc., if resolv.conf is not going to be updated
later anyway. E.g.,

- # If the resolv.conf file has not been modified, and the PPP
- # resolv.conf has, copy it into place
- while(1) {
+ # If the resolv.conf file has not been modified and is not
+ # a symlink, and the pppd-generated resolv.conf file has
+ # been modified, then copy the latter over the former
+ if (!-l $resolv_conf) while (1)

I haven't tested this.
--
Thomas Hood <email address hidden>

Revision history for this message
In , Frank Lichtenheld (djpig) wrote :

On Sat, Jan 08, 2005 at 04:56:24PM +0100, Thomas Hood wrote:
> The patch looks OK. My only comment would be that you might want to put
> the "-l $resolv_conf" test up higher since there may be no point to
> executing the sleep(3), etc., if resolv.conf is not going to be updated
> later anyway. E.g.,
>
> - # If the resolv.conf file has not been modified, and the PPP
> - # resolv.conf has, copy it into place
> - while(1) {
> + # If the resolv.conf file has not been modified and is not
> + # a symlink, and the pppd-generated resolv.conf file has
> + # been modified, then copy the latter over the former
> + if (!-l $resolv_conf) while (1)
>
> I haven't tested this.

Good suggestion. Modified my patch and uploaded 1.160-3.

Gruesse,
--
Frank Lichtenheld <email address hidden>
www: http://www.djpig.de/

Revision history for this message
In , Frank Lichtenheld (djpig) wrote : Bug#288481: fixed in webmin-optional 1.160-3
Download full text (11.6 KiB)

Source: webmin-optional
Source-Version: 1.160-3

We believe that the bug you reported is fixed in the latest version of
webmin-optional, which is due to be installed in the Debian FTP archive:

webmin-adsl_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-adsl_1.160-3_all.deb
webmin-apache_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-apache_1.160-3_all.deb
webmin-burner_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-burner_1.160-3_all.deb
webmin-cfengine_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-cfengine_1.160-3_all.deb
webmin-cpan_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-cpan_1.160-3_all.deb
webmin-dhcpd_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-dhcpd_1.160-3_all.deb
webmin-exports_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-exports_1.160-3_all.deb
webmin-freeswan_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-freeswan_1.160-3_all.deb
webmin-frox_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-frox_1.160-3_all.deb
webmin-fsdump_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-fsdump_1.160-3_all.deb
webmin-heartbeat_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-heartbeat_1.160-3_all.deb
webmin-htaccess_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-htaccess_1.160-3_all.deb
webmin-jabber_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-jabber_1.160-3_all.deb
webmin-ldap-useradmin_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-ldap-useradmin_1.160-3_all.deb
webmin-logrotate_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-logrotate_1.160-3_all.deb
webmin-lpadmin_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-lpadmin_1.160-3_all.deb
webmin-mailboxes_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-mailboxes_1.160-3_all.deb
webmin-mon_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-mon_1.160-3_all.deb
webmin-mysql_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-mysql_1.160-3_all.deb
webmin-openslp_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-openslp_1.160-3_all.deb
webmin-optional_1.160-3.diff.gz
  to pool/main/w/webmin-optional/webmin-optional_1.160-3.diff.gz
webmin-optional_1.160-3.dsc
  to pool/main/w/webmin-optional/webmin-optional_1.160-3.dsc
webmin-postgresql_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-postgresql_1.160-3_all.deb
webmin-ppp_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-ppp_1.160-3_all.deb
webmin-pptp-client_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-pptp-client_1.160-3_all.deb
webmin-pptp-server_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-pptp-server_1.160-3_all.deb
webmin-procmail_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-procmail_1.160-3_all.deb
webmin-pserver_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-pserver_1.160-3_all.deb
webmin-quota_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-quota_1.160-3_all.deb
webmin-samba_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-samba_1.160-3_all.deb
webmin-software_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-software_1.160-3_all.deb
webmin-spamassassin_1.160-3_all.deb
  to pool/main/w/webmin-optio...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Sat, 8 Jan 2005 18:55:45 +0100
From: Frank Lichtenheld <email address hidden>
To: Thomas Hood <email address hidden>, <email address hidden>
Subject: Re: Bug#288481: if there is nothing, you might as well close it

On Sat, Jan 08, 2005 at 04:56:24PM +0100, Thomas Hood wrote:
> The patch looks OK. My only comment would be that you might want to put
> the "-l $resolv_conf" test up higher since there may be no point to
> executing the sleep(3), etc., if resolv.conf is not going to be updated
> later anyway. E.g.,
>
> - # If the resolv.conf file has not been modified, and the PPP
> - # resolv.conf has, copy it into place
> - while(1) {
> + # If the resolv.conf file has not been modified and is not
> + # a symlink, and the pppd-generated resolv.conf file has
> + # been modified, then copy the latter over the former
> + if (!-l $resolv_conf) while (1)
>
> I haven't tested this.

Good suggestion. Modified my patch and uploaded 1.160-3.

Gruesse,
--
Frank Lichtenheld <email address hidden>
www: http://www.djpig.de/

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (11.8 KiB)

Message-Id: <email address hidden>
Date: Sat, 08 Jan 2005 13:17:22 -0500
From: Frank Lichtenheld <email address hidden>
To: <email address hidden>
Subject: Bug#288481: fixed in webmin-optional 1.160-3

Source: webmin-optional
Source-Version: 1.160-3

We believe that the bug you reported is fixed in the latest version of
webmin-optional, which is due to be installed in the Debian FTP archive:

webmin-adsl_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-adsl_1.160-3_all.deb
webmin-apache_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-apache_1.160-3_all.deb
webmin-burner_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-burner_1.160-3_all.deb
webmin-cfengine_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-cfengine_1.160-3_all.deb
webmin-cpan_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-cpan_1.160-3_all.deb
webmin-dhcpd_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-dhcpd_1.160-3_all.deb
webmin-exports_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-exports_1.160-3_all.deb
webmin-freeswan_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-freeswan_1.160-3_all.deb
webmin-frox_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-frox_1.160-3_all.deb
webmin-fsdump_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-fsdump_1.160-3_all.deb
webmin-heartbeat_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-heartbeat_1.160-3_all.deb
webmin-htaccess_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-htaccess_1.160-3_all.deb
webmin-jabber_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-jabber_1.160-3_all.deb
webmin-ldap-useradmin_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-ldap-useradmin_1.160-3_all.deb
webmin-logrotate_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-logrotate_1.160-3_all.deb
webmin-lpadmin_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-lpadmin_1.160-3_all.deb
webmin-mailboxes_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-mailboxes_1.160-3_all.deb
webmin-mon_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-mon_1.160-3_all.deb
webmin-mysql_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-mysql_1.160-3_all.deb
webmin-openslp_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-openslp_1.160-3_all.deb
webmin-optional_1.160-3.diff.gz
  to pool/main/w/webmin-optional/webmin-optional_1.160-3.diff.gz
webmin-optional_1.160-3.dsc
  to pool/main/w/webmin-optional/webmin-optional_1.160-3.dsc
webmin-postgresql_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-postgresql_1.160-3_all.deb
webmin-ppp_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-ppp_1.160-3_all.deb
webmin-pptp-client_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-pptp-client_1.160-3_all.deb
webmin-pptp-server_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-pptp-server_1.160-3_all.deb
webmin-procmail_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-procmail_1.160-3_all.deb
webmin-pserver_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-pserver_1.160-3_all.deb
webmin-quota_1.160-3_all.deb
  to pool/main/w/webmin-optional/webmin-quota_1.160-3_all.deb
webmin-samba_1.160-3_all.deb
  to...

Bug Watch Updater (bug-watch-updater)
Changed in wvdial:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.