Comment 21 for bug 11626

Message-ID: <email address hidden>
Date: Sat, 8 Jan 2005 18:55:45 +0100
From: Frank Lichtenheld <email address hidden>
To: Thomas Hood <email address hidden>, <email address hidden>
Subject: Re: Bug#288481: if there is nothing, you might as well close it

On Sat, Jan 08, 2005 at 04:56:24PM +0100, Thomas Hood wrote:
> The patch looks OK. My only comment would be that you might want to put
> the "-l $resolv_conf" test up higher since there may be no point to
> executing the sleep(3), etc., if resolv.conf is not going to be updated
> later anyway. E.g.,
>
> - # If the resolv.conf file has not been modified, and the PPP
> - # resolv.conf has, copy it into place
> - while(1) {
> + # If the resolv.conf file has not been modified and is not
> + # a symlink, and the pppd-generated resolv.conf file has
> + # been modified, then copy the latter over the former
> + if (!-l $resolv_conf) while (1)
>
> I haven't tested this.

Good suggestion. Modified my patch and uploaded 1.160-3.

Gruesse,
--
Frank Lichtenheld <email address hidden>
www: http://www.djpig.de/