Comment 18 for bug 11626

Message-Id: <1105199784.8723.17.camel@thanatos>
Date: Sat, 08 Jan 2005 16:56:24 +0100
From: Thomas Hood <email address hidden>
To: Frank Lichtenheld <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#288481: if there is nothing, you might as well close it

On Sat, 2005-01-08 at 14:59 +0100, Frank Lichtenheld wrote:
> I'm currently preparing a QA upload for the orphaned webmin-optional
> package. Could you please take a look at the attached patch andtell
> if you would consider it sufficient? I tried to take a less invasive
> approach than completly removing the code since I don't want to
> introduce too great change in behaviour in a QA upload.

The patch looks OK. My only comment would be that you might want to put
the "-l $resolv_conf" test up higher since there may be no point to
executing the sleep(3), etc., if resolv.conf is not going to be updated
later anyway. E.g.,

- # If the resolv.conf file has not been modified, and the PPP
- # resolv.conf has, copy it into place
- while(1) {
+ # If the resolv.conf file has not been modified and is not
+ # a symlink, and the pppd-generated resolv.conf file has
+ # been modified, then copy the latter over the former
+ if (!-l $resolv_conf) while (1)

I haven't tested this.
--
Thomas Hood <email address hidden>