test_auth_token_middleware encounters unlimited recursion

[Alexej Ababilov]

test_auth_token_middleware are somehow skipped in OpenStack unit test jobs. These tests fail:

ERROR: tests.test_auth_token_middleware.AuthTokenMiddlewareTest.test_assert_valid_memcache_protection_config
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/tmp/yahoo/python-keystoneclient/tests/test_auth_token_middleware.py", line 366, in setUp
    super(BaseAuthTokenMiddlewareTest, self).setUp()
  File "/tmp/yahoo/python-keystoneclient/tests/test_auth_token_middleware.py", line 366, in setUp
    super(BaseAuthTokenMiddlewareTest, self).setUp()
...
  File "/tmp/yahoo/python-keystoneclient/tests/test_auth_token_middleware.py", line 366, in setUp
    super(BaseAuthTokenMiddlewareTest, self).setUp()
  File "/tmp/yahoo/python-keystoneclient/tests/test_auth_token_middleware.py", line 366, in setUp
    super(BaseAuthTokenMiddlewareTest, self).setUp()
RuntimeError: maximum recursion depth exceeded while calling a Python object

The recursion occurs here:

 class BaseAuthTokenMiddlewareTest(testtools.TestCase):

     def setUp(self, expected_env=None):
        super(BaseAuthTokenMiddlewareTest, self).setUp() # calls the same setUp for Python 2.6!
...
if tuple(sys.version_info)[0:2] < (2, 7):

    # 2.6 doesn't have the assert dict equals so make sure that it exists
    class AdjustedBaseAuthTokenMiddlewareTest(BaseAuthTokenMiddlewareTest):
              ....
    BaseAuthTokenMiddlewareTest = AdjustedBaseAuthTokenMiddlewareTest

For Python 2.6, BaseAuthTokenMiddlewareTest will be equal to AdjustedBaseAuthTokenMiddlewareTest in BaseAuthTokenMiddlewareTest.setUp thus leading to infinite recursion.

Also, parent's setUp is called by BaseAuthTokenMiddlewareTest.setUp twice by mistake: at the beginning and at the end of the function.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/22325

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/22325
Committed: http://github.com/openstack/python-keystoneclient/commit/e844d75277254669a2c029c6536ef0b090524747
Submitter: Jenkins
Branch: master

commit e844d75277254669a2c029c6536ef0b090524747
Author: Alessio Ababilov <email address hidden>
Date: Tue Feb 19 17:58:44 2013 +0200

    Save test_auth_token_middleware from unlimited recursion

    For Python 2.6, BaseAuthTokenMiddlewareTest will be
    equal to AdjustedBaseAuthTokenMiddlewareTest in
    BaseAuthTokenMiddlewareTest.setUp thus leading to
    infinite recursion.

    Also, parent's setUp was incorrectly called by
    BaseAuthTokenMiddlewareTest.setUp twice: at the beginning
    and at the end of the function.

    Change-Id: I63fce65866ef9d8aebe9eb60f7ceb17463de0989
    Fixes: bug #1130200