geoclue-ubuntu-geoip doesn't support proxies

Bug #1130097 reported by Jonathan Davies
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu GeoIP
Fix Released
High
Ted Gould
ubuntu-geoip (Ubuntu)
Fix Released
Medium
Unassigned
Declined for Quantal by Sebastien Bacher
Precise
Fix Released
Low
Ritesh Khadgaray

Bug Description

geoclue-ubuntu-geoip doesn't seem to support proxy settings, even when they're set in /etc/environment or the System Settings → Network section.

This would be useful for corporate networks where outgoing HTTP is blocked, except for when allowed via a proxy.

[Impact]
System components should respect system proxy settings.

[Test Case]
With non-patched packages, run: kill -9 the geoclue-master and ubuntu-geoip-provider processes while running tcpdump on ports 80 and the port of one's HTTP proxy server.

One will see the connections go straight to port 80 on the IPs above rather than via the proxy.

[Regression Potential]
None.

Related branches

Jonathan Davies (jpds)
description: updated
Jonathan Davies (jpds)
description: updated
Ted Gould (ted)
Changed in ubuntu-geoip:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Ted Gould (ted)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-geoip at revision 34, scheduled for release in ubuntu-geoip, milestone 1.0.0

Changed in ubuntu-geoip:
status: In Progress → Fix Committed
Jonathan Davies (jpds)
description: updated
Jonathan Davies (jpds)
Changed in ubuntu-geoip (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Jonathan Davies (jpds)
Changed in ubuntu-geoip (Ubuntu):
assignee: nobody → Ritesh Khadgaray (khadgaray)
Revision history for this message
Ritesh Khadgaray (khadgaray) wrote :
Revision history for this message
Ritesh Khadgaray (khadgaray) wrote :
Changed in ubuntu-geoip (Ubuntu Precise):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work there, I've backported the fixes to raring (pre-required for a SRU), I'm sponsoring the precise SRU but declining the quantal one since we try to minimize work on nonLTS series. Feel free to me ping me directly if you really need it upload to the quantal serie though, we can discuss it

Changed in ubuntu-geoip (Ubuntu):
assignee: Ritesh Khadgaray (khadgaray) → nobody
Changed in ubuntu-geoip (Ubuntu Precise):
assignee: nobody → Ritesh Khadgaray (khadgaray)
Changed in ubuntu-geoip (Ubuntu):
status: Triaged → Fix Committed
Changed in ubuntu-geoip (Ubuntu Precise):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-geoip - 1.0.1-0ubuntu4

---------------
ubuntu-geoip (1.0.1-0ubuntu4) raring; urgency=low

  * Backport upstream commits:
    - Fix ordering of parameters (lp: #1067037)
    - support for proxies (lp: #1130097)
  * debian/control:
    - Build-depends on libsoup-gnome2.4-dev
 -- Sebastien Bacher <email address hidden> Fri, 15 Mar 2013 11:53:53 +0100

Changed in ubuntu-geoip (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jonathan, or anyone else affected,

Accepted ubuntu-geoip into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-geoip/0.0.2-0ubuntu6.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-geoip (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Jonathan, or anyone else affected,

Accepted ubuntu-geoip into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-geoip/0.0.2-0ubuntu6.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Jonathan Davies (jpds) wrote :

Patch is missing from debian/patches/series.

tags: added: verification-failed
removed: verification-needed
Revision history for this message
Sebastien Bacher (seb128) wrote :

third try, should be fix this time... sorry about that

@Jonathan: would be nice if you guys did test-build the version you use to submit debdiffs as well... ;-)

Revision history for this message
Jonathan Davies (jpds) wrote :

Package verified as OK.

tags: added: verification-done
removed: verification-failed
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-geoip - 0.0.2-0ubuntu6.3

---------------
ubuntu-geoip (0.0.2-0ubuntu6.3) precise; urgency=low

  * debian/patches/series: list the patch in the serie as well...

ubuntu-geoip (0.0.2-0ubuntu6.2) precise; urgency=low

  * debian/control: build-depends on dh-autoreconf for the previous change

ubuntu-geoip (0.0.2-0ubuntu6.1) precise; urgency=low

  * debian/control: inlcude libsoup-gnome-dev in build dep
  * debian/rules: rebuild configure file
  * debian/patches/proxy.patch: add proxy support (lp: #1130097)
 -- Sebastien Bacher <email address hidden> Thu, 21 Mar 2013 18:19:05 +0100

Changed in ubuntu-geoip (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

Small status update, raring started receiving a number of segfault with this change: bug #1157232

The issue seems rather in libproxy than ubuntu-geoip and errors.ubuntu.com doesn't suggest it impacts precise

Ted Gould (ted)
Changed in ubuntu-geoip:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.