PositionChanged signal arguments are in the wrong order
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu GeoIP |
Fix Released
|
Low
|
Unassigned | ||
ubuntu-geoip (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
[I tried to generate a patch with commit message and such form my local bzr commit but I failed. Thus I'm putting this here. Should be easy enough to pick it up and commit it on your side.]
--- Commit message ---
Fix the argument ordering of the position signal.
Signals are supposed to be emitted with the same argument ordering as the reply
of the method call. Fields comes before the timestamp here. This is the way the
geoclue dbus spec describes it and the other provider implementing it.
Be aware that it my break applications that have been developed for the Ubuntu
provider only and are listening for position signals.
Signed-off-by: Stefan Schmidt <email address hidden>
------
Without this patch the timestamp gets used for the fields and surprising results are the outcome. The attched patch fixes this issue for me.
Related branches
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 13 lines (+1/-1)1 file modifiedsrc/ubuntu-geoip-provider.c (+1/-1)
Changed in ubuntu-geoip (Ubuntu): | |
importance: | Undecided → Low |
Changed in ubuntu-geoip: | |
importance: | Undecided → Low |
Changed in ubuntu-geoip (Ubuntu): | |
status: | New → Fix Committed |
Changed in ubuntu-geoip: | |
status: | Fix Committed → Fix Released |
Any comments on the patch?