Change pieforms to allow for the same lang string non-capitalized

Bug #1100980 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Doris Tam

Bug Description

Bug 952625 changed the registration expiry time to a configurable option using the strings provided in the drop-down menu. These are capitalized, but the strings should actually have a lower-case initial letter because it appears in a sentence.

Pieforms need to be changed to allow two different strings depending on the context where the word appears or maybe there is a different solution.

Revision history for this message
Doris Tam (doristam) wrote :

Looks like this has been resolved https://bugs.launchpad.net/mahara/+bug/1773600

Revision history for this message
Doris Tam (doristam) wrote :

Take that back. This is different, but will work with the new code from that patch

Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11452

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11452
Committed: https://git.mahara.org/mahara/mahara/commit/bbfc38d3ddec92736e9c377c207eb3cbc488aba3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bbfc38d3ddec92736e9c377c207eb3cbc488aba3
Author: Doris Tam <email address hidden>
Date: Tue Nov 17 13:41:37 2020 +1300

Bug 1100980: Changing the expiry type form language strings to lowercase

To be more appropriate gramatically as they are used only at the end of sentences.

behatnotneeded

Change-Id: Iedca86f1ddaf43b8bda5b193beadc9c45b5fe70e

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 21.04.0
status: In Progress → Fix Committed
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.