Pending registrations have an unreasonable expiry time

Bug #952625 reported by Hugh Davenport
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Ali Kaye

Bug Description

The current setting is hard coded as a week after the user comfirms their email address. This setting should be configurable by site.
Reasons behind this is that admins may go extended periods without logging into mahara (ie, due to a break in school terms etc). Because of this, they may not be able to confirm or deny the pending registration in the current weeks allocation. In addition, the current email sent doesn't have any mention of the time limit.

To fix this, I would suggest that we make a configurable option for the expiry time (and also maybe do the same for the user registration links sent out, which are currently 24 hours hard coded), and also change the wording of the email sent to admins noting the expiry time.

This bug is related to bug #918431

Changed in mahara:
assignee: nobody → Hugh Davenport (hugh-catalyst)
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

The original bug for this implementation was bug #662775, commited as f46e341ec340d0bf404d79ee718bdc42746eb117

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

Temporary fix available here, just changes hard coded limit to 2 weeks, and adds a hard coded message to the email sent to admins

https://reviews.mahara.org/1094

Changed in mahara:
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1094
Committed: http://gitorious.org/mahara/mahara/commit/3e9b3dd12a448b1aa232e5e715b2a70d5f67935b
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 3e9b3dd12a448b1aa232e5e715b2a70d5f67935b
Author: Hugh Davenport <email address hidden>
Date: Mon Mar 12 13:39:26 2012 +1300

    Change pending registration expiry time to 2 weeks

    Also adds a message to the email sent to admins to that effect

    This is a temporary fix for bug #952625 until a new feature can
    be introduced to add a config option for this time limit.

    Change-Id: I898759db8e5eb4cfb8c1eead8b7ac006c6f97197
    Signed-off-by: Hugh Davenport <email address hidden>

Changed in mahara:
status: In Progress → Triaged
assignee: Hugh Davenport (hugh-catalyst) → nobody
Changed in mahara:
assignee: nobody → Ali Kaye (alexandrakaye-student)
status: Triaged → In Progress
Revision history for this message
Ali Kaye (alexandrakaye-student) wrote :
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
milestone: none → 1.7.0
tags: added: nominatedfeature
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.