Record navigation template has a translatable arrow
Bug #1095290 reported by
Pasi Kallinen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
2.5 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.6 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.7 |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Wraps all the navigation arrow characters in the nav_arrow_fix span, and moves the arrow outside the translatable string - it makes no sense having it translatable.
Changed in evergreen: | |
status: | New → Triaged |
Changed in evergreen: | |
milestone: | none → 2.4.0-rc |
Changed in evergreen: | |
milestone: | 2.4.0-rc → 2.5.0-alpha |
Changed in evergreen: | |
milestone: | 2.5.0-m1 → 2.5.0-m2 |
Changed in evergreen: | |
milestone: | 2.5.0-m2 → 2.5.0-alpha1 |
Changed in evergreen: | |
milestone: | 2.5.0-alpha1 → 2.5.0-alpha2 |
Changed in evergreen: | |
milestone: | 2.5.0-alpha2 → 2.5.0-beta1 |
Changed in evergreen: | |
milestone: | 2.5.0-beta1 → 2.5.0-rc |
Changed in evergreen: | |
milestone: | 2.5.0-rc → 2.5.1 |
Changed in evergreen: | |
milestone: | 2.5.1 → 2.5.2 |
importance: | Undecided → Medium |
Changed in evergreen: | |
milestone: | 2.5.2 → 2.6.0-alpha1 |
Changed in evergreen: | |
milestone: | 2.6.0-alpha1 → 2.6.0-beta1 |
Changed in evergreen: | |
milestone: | 2.6.0-beta1 → 2.6.0-rc1 |
Changed in evergreen: | |
milestone: | 2.6.0-rc1 → 2.next |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Well, actually... we've had people who have wanted to use different arrow characters, for whatever reason. Having it be translatable makes it easier to supply a different tpac.po file. Whether it's translatable or not, it should at least be consistent, though, which it is not currently. Also, I dunno - would it make sense for a right-to-left language to want to put the arrow symbol on the other side and facing the other way?
Aside: in your branch, was there a reason to wrap the arrows in <span> tags? That seems to introduce extra markup for no discernible reason.