Naim returns erroneous error messages

[carlosqueso]

Binary package hint: naim

Naim 0.11.8-1 shows "ERROR: Server response was formatted incorrectly, can't find username in info HTML" at random times. This is fixed in upstream version 0.11.8.2.1. Reccomend an upgrade, as it builds cleanly without breaking anything on fiesty.

[Andrew Chin (achin)]

version 0.11.8.3.1 is now the latest upstream. It also builds cleanly without any breakage on gutsy

upgrade recommended as well.

http://naim.googlecode.com/files/naim-0.11.8.3.1.tar.bz2

[James (jbertelson)]

The linked version builds fine on Hardy as well.

[James (jbertelson)]

Built the new version on Hardy -- attatched is a debdiff of the old and new .dsc's.

[James (jbertelson)]

.deb package of same.

[James (jbertelson)]

.dsc diff

[Daniel Holbach (dholbach)]

Can you please attach the .dsc and .diff.gz file of the new 0.11.8.2.1 source package?

[Luca Falavigna (dktrkranz)]

Please resubscribe ubuntu-universe-sponsors after attaching new .diff.gz for review. Thanks!

[protomech (mbeatty)]

Please see attached new .diff.gz against naim-0.8.3.1 ..

[protomech (mbeatty)]

And .dsc. Hope this is the right format.

[Luca Falavigna (dktrkranz)]

What about change in src/main.c? You dropped it, is there a reason behind this choice?

[James (jbertelson)]

I'm sorry, but I need to rant for a second. In the time that the ubuntu staff/higher up bug killers have spent trying to follow 'protocol' this bug could have LONG since been fixed and pushed out. Yes, I've never packaged for ubuntu before and ended up sending in the wrong attachments. That's great(the lack of documentation is a big plus too) but seriously. This bug is going on two years old, and is far from a complex fix.

[Joshua Wise (joshua-joshuawise)]

Is there an update on this? We'd love to give Ubuntu a gold star again on http://naim.n.ml.org/packages :-)

[Siegfried Gevatter (rainct)]

protomech:

I have an upload ready, but first could you please justify why the attached changes were dropped?

Thanks!

[protomech (mbeatty)]

Sorry, thought I had updated this..

I made a mistake when I patched the package earlier, resulting in the dropped changes.

Here's a second stab at an updated package:

* earlier screen sessions patch retained
* debian/control modified with update-maintainer tool
* debian/watch field added to grab / repack the .tar.gz from the .tar.bz2 (uscan --repack)

I have tried to contact the debian naim package maintainer, have not received a response.

[protomech (mbeatty)]

signed files. The tarball is converted with uscan, which places a modified time in the MTIME field of the gzip file .. unfortunately this means that signing the converted tarball is not very useful.

$ uscan --verbose --repack --force-download # generates naim_0.11.8.3.1.orig.tar.gz
$ wget -O - http://naim.googlecode.com/files/naim-0.11.8.3.1.tar.bz2 | bzcat | gzip -n > naim-0.11.8.3.1.orig.tar.gz.2

$ xxd naim-0.8.3.1.orig.tar.gz > xxd.1
$ xxd naim-0.8.3.1.orig.tar.gz > xxd.2
$ diff -ub xxd.1 xxd.2
--- xxd.1 2009-02-09 13:30:05.000000000 -0600
+++ xxd.2 2009-02-09 13:30:13.000000000 -0600
@@ -1,4 +1,4 @@
-0000000: 1f8b 0800 af82 9049 0003 ec5b fb73 db46 .......I...[.s.F
+0000000: 1f8b 0800 0000 0000 0003 ec5b fb73 db46 ...........[.s.F
 0000010: 92ce afc1 5f31 6192 92b4 4591 a22c db89 ...._1a...E..,..
 0000020: d7f1 4596 a598 57b6 a448 d4e5 5271 ce19 ..E...W..H..Rq..
 0000030: 0243 1211 8861 3080 6826 e7fd dbef ebee .C...a0.h&......

Open to suggestions on a better way to handle this..

[protomech (mbeatty)]

Should be:
$ xxd naim_0.11.8.3.1.orig.tar.gz > xxd.1
$ xxd naim_0.11.8.3.1.orig.tar.gz.2 > xxd.2

This is an ugly workaround..

[Siegfried Gevatter (rainct)]

Hi.

Here are some more mistakes I've found. You don't need to upload a new .diff.gz (I've already fixed them locally), but I'm explaining them so that you don't repeat them in the future:

* Your .diff.gz contained changes which were automatically done by autotools and which aren't necessary there. In the future please check the .diff.gz/.debdiff files you upload in case there is something there which you haven't touched, and if so remove it (and ensure that the the patch still works afterwards).

* The syntax for closing a Launchpad bug is "LP: #xxxx", not "Closes:". Also, uploads like this always are for the current development release (which now is "jaunty", not "hardy").

* Recently it was decided that the Maintainer field change doesn't need to be documented in debian/changelog any more. (In case you used the update-maintainer script, newer versions of it don't touch the changelog anymore).

And finally the most important one, which is why I haven't uploaded this yet. Instead of modifying main.c, you have included a file called naim-scrensessions.diff and which contains the changes (but that file isn't used for anything). I guess this was a mistake and you wanted to patch main.c instead, but can you please confirm this?

Thanks!

[protomech (mbeatty)]

Hi Siegfried,

Thanks for your suggestions. For context, the latest version of the package appears to be an ubuntu import from debian. I'm afraid the changes I made were partially based on the earlier debian changes, so I may have mixed the syntax.

I'll respond in order:

* Noted.

* Noted. I'm running hardy; can I just change the release tag in debian/changelog, or will running an older system cause further problems with the release?

* Yes, I was using the update-maintainer script to modify debian/control, I noted this change in the changelog manually.

* In my initial post (2009-01-13), I mistakenly dropped the changes from src/main.c. My more recent .diff.gz submission (2009-02-09) should properly patch src/main.c. The patch file (naim-scrensessions.diff) is carried over from the last debian .diff.gz - please drop it if it does not belong.

The screen patch appears to be applied properly when I check. I can reverse the screen patch successfully after applying my latest .diff.gz submission.

$ tar xfz naim_0.11.8.3.1.orig.tar.gz
$ cd naim-0.11.8.3.1/
$ zcat ../naim_0.11.8.3.1-0ubuntu1.diff.gz | patch -p1
patching file config.sub
patching file src/main.c
patching file debian/compat
patching file debian/changelog
patching file debian/docs
patching file debian/control
patching file debian/copyright
patching file debian/watch
patching file debian/naim.1
patching file debian/rules
patching file naim-scrensessions.diff
patching file config.guess
$ patch -p1 -R < naim-scrensessions.diff
patching file src/main.c

Am I missing something?

Thanks again.

[Launchpad Janitor (janitor)]

This bug was fixed in the package naim - 0.11.8.3.1-0ubuntu1

---------------
naim (0.11.8.3.1-0ubuntu1) jaunty; urgency=low

  * New upstream release
  * Fixes the userinfo bug (LP: #109289)
  * Add debian/watch file.

 -- Michael Beatty <email address hidden> Mon, 12 Jan 2009 17:53:50 -0600

[Siegfried Gevatter (rainct)]

Oh, right. I hadn't seen that your .diff.gz also touches the main.c file directly (file naim-scrensessions.diff is unnecessary and may have been added by mistake.. I've deleted it for now). I've uploaded the package now :).

And yes, you can make packages for intrepid on hardy, just be sure to test that they build correctly. You have instructions on an easy way to do this here: http://bloc.eurion.net/archives/2009/test-build-debian-packages/

----------------

Before someone asks, this new version is now in Jaunty, not in Hardy and no in Intrepid, and it is extremely unlikely that it'll get there (unless it's into the -backports repository, in case the new version has some interesting feature). If you thing this bug is important enough to be fixed in Hardy/Intrepid, the fix will need to be isolated so that we can upload a new version with just the minimal change. See https://wiki.ubuntu.com/StableReleaseUpdates for more information.