Comment 17 for bug 109289

Hi.

Here are some more mistakes I've found. You don't need to upload a new .diff.gz (I've already fixed them locally), but I'm explaining them so that you don't repeat them in the future:

* Your .diff.gz contained changes which were automatically done by autotools and which aren't necessary there. In the future please check the .diff.gz/.debdiff files you upload in case there is something there which you haven't touched, and if so remove it (and ensure that the the patch still works afterwards).

* The syntax for closing a Launchpad bug is "LP: #xxxx", not "Closes:". Also, uploads like this always are for the current development release (which now is "jaunty", not "hardy").

* Recently it was decided that the Maintainer field change doesn't need to be documented in debian/changelog any more. (In case you used the update-maintainer script, newer versions of it don't touch the changelog anymore).

And finally the most important one, which is why I haven't uploaded this yet. Instead of modifying main.c, you have included a file called naim-scrensessions.diff and which contains the changes (but that file isn't used for anything). I guess this was a mistake and you wanted to patch main.c instead, but can you please confirm this?

Thanks!