[Sync libgpod 0.8.2-7 from Debian unstable to Raring] libgpod-cil contains arch-specific code but is declared arch:all

[Chow Loong Jin]

  subscribe ubuntu-archive

  affects ubuntu/libgpod
  status triaged

  affects ubuntu/quantal/libgpod
  status inprogress
  assignee hyperair

From http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689054,

libgpod-cil package of the libgpod project has a wrong architecture entry:
- Normally -cil packages are arch-independent but,
- This one isn't because the library contains interoperability/marshalling
(unsafe) code.
- Package should be compiled differently, then, in each arch.
- Proof of this is the file configure.ac of upstream:
http://gtkpod.git.sourceforge.net/git/gitweb.cgi?p=gtkpod/libgpod;a=blob;f=configure.ac;h=669d433a47536ed5504eed12766f4876b476efa6;hb=HEAD
(Line 318, with different GMCS_FLAGS determined by ac_cv_alignof_double)
- The upstream bug is: https://bugzilla.gnome.org/show_bug.cgi?id=684876

Additionally, Banshee will need to be rebuilt to pick up the changes.
  affects ubuntu/banshee
  assignee hyperair

  affects ubuntu/quantal/banshee

[Proposed Fix]
libgpod has already been fixed in Debian unstable, and will migrate to Debian
testing in 3 days. Hence all we need to do is sync libgpod 0.8.2-7 to Ubuntu
Raring, and backport this fix into quantal-proposed.

After that, Banshee will need to be rebuilt on Quantal and Raring.

[IMPACT]
Banshee users on 64-bit platforms (amd64) end up with packages that are built
for 32-bit platforms (i386), resulting in alignment issues resulting in
bgo#684876. It is unknown if any other issues are caused by this bug.

[TESTCASE]
1. Launch Banshee
2. Plug in iPod
3. Sync some playlists into the iPod.
4. Disconnect the iPod, and plug it back in.
5. Repeat steps 1-4, and see if the playlists are duplicated on the iPod.

[Regression Potential]
None for i386 users, and non-libgpod-cil users, as the changes only touch the
.NET bindings on non-i386 architectures. The binaries for i386 will remain
unchanged, as that's the arch libgpod-cil is built on for arch:all libgpod-cil.

The only known user of libgpod-cil is Banshee, which is already afflicted by
bgo#689054. Since the arch-specific changes only involve changing struct
alignment parameters, which were set incorrectly on 64-bit architectures in the
first place, the regression potential here is minimal as well.

--
Kind regards,
Loong Jin

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Chow Loong Jin (hyperair)]

Here's a patch for the Quantal SRU of libgpod.

[Luke Yelavich (themuso)]

That quantal patch only contains a changelog entry.

[Chow Loong Jin (hyperair)]

Here you go.

[Benjamin Drung (bdrung)]

Why do you add "[amd64 armel armhf i386 ia64 kfreebsd-amd64 kfreebsd-i386 powerpc ppc64 s390x sparc]" to the build dependencies that you move from -indep? Why don't you use "Architecture: any"?

Unsubscribing ubuntu-sponsors for now. Please resubscribe after providing an updated patch.

[Chow Loong Jin (hyperair)]

On 21/11/2012 21:40, Benjamin Drung wrote:
> Why do you add "[amd64 armel armhf i386 ia64 kfreebsd-amd64
> kfreebsd-i386 powerpc ppc64 s390x sparc]" to the build dependencies that
> you move from -indep? Why don't you use "Architecture: any"?
>
> Unsubscribing ubuntu-sponsors for now. Please resubscribe after
> providing an updated patch.
>

Because mono doesn't build on everything, and you would not get the native
libgpod on non-mono arches if I didn't do that.

  subscribe ubuntu-sponsors

--
Kind regards,
Loong Jin

[Benjamin Drung (bdrung)]

I uploaded your fix to quantal-proposed after fixing the changelog entry (your patch was created against 0.8.2-6 instead of 0.8.2-6build1).

I thinks it's better to use "Architecture: any" and exclude the unsupported architectures. mono is available on all Ubuntu architectures. "Architecture any [!hurd-i386 !mips !mipsel !s390]" is shorter than "Architecture: amd64 armel armhf i386 ia64 kfreebsd-amd64 kfreebsd-i386 powerpc ppc64 s390x sparc"

[Chow Loong Jin (hyperair)]

On 23/11/2012 09:03, Benjamin Drung wrote:
> I uploaded your fix to quantal-proposed after fixing the changelog entry
> (your patch was created against 0.8.2-6 instead of 0.8.2-6build1).
>
> I thinks it's better to use "Architecture: any" and exclude the
> unsupported architectures. mono is available on all Ubuntu
> architectures. "Architecture any [!hurd-i386 !mips !mipsel !s390]" is
> shorter than "Architecture: amd64 armel armhf i386 ia64 kfreebsd-amd64
> kfreebsd-i386 powerpc ppc64 s390x sparc"
>

Oh, thanks. I hadn't known of that syntax. I'll do that in Debian as well.

--
Kind regards,
Loong Jin

[Brian Murray (brian-murray)]

Hello Chow, or anyone else affected,

Accepted libgpod into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libgpod/0.8.2-6ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris Halse Rogers (raof)]

Hello Chow, or anyone else affected,

Accepted banshee into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/banshee/2.6.0-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Andres G. Aragoneses (knocte)]

Upstream bug is https://bugzilla.gnome.org/show_bug.cgi?id=684876 (although it shouldn't be filed upstream if we confirm that it was a packaging bug ;) )

I've proposed the bug reporter to verify the fix. I'll test myself too when I have some spare time soon.
Thanks

[Andres G. Aragoneses (knocte)]

We're already 2 people that installed the new package and confirm it works. Thanks very much.

Is this verification enough to move it from quantal-proposed to reach all ubuntus?

[Benjamin Drung (bdrung)]

Yes, it is.

[Chris Halse Rogers (raof)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package banshee - 2.6.0-1ubuntu2.1

---------------
banshee (2.6.0-1ubuntu2.1) quantal-proposed; urgency=low

  * [6027e9f] Bump libgpod build-dep version to 0.8.2-6ubuntu1.
    This is to pick up the arch-specific libgpod.dll binary (LP: #1070631)
 -- Chow Loong Jin <email address hidden> Sat, 01 Dec 2012 12:56:46 +0800

[Launchpad Janitor (janitor)]

This bug was fixed in the package libgpod - 0.8.2-6ubuntu1

---------------
libgpod (0.8.2-6ubuntu1) quantal-proposed; urgency=low

  * [1c86366] Make -cil packages non-arch-all (Closes: #689054, LP: #1070631)
  * [409b51d] Add armhf to list of architectures
 -- Chow Loong Jin <email address hidden> Wed, 14 Nov 2012 13:48:47 +0800