[Precise only] Some keyboard navigation breakage with GTK Notebook

[Attila Hammer]

Dear Developers,

In Ubuntu 12.04 with GTK notebook containing dialogs some time keyboard navigation is broken if the user using SHIFT+TAB key combination. I copying test case for bug 669986 upstream report, with already fixed I think in GTK+ 3.5.6. The fix is land correct in Ubuntu Quantal too.
Joanmarie Diggs Orca developer in upstream report wrote following testcase:Steps to reproduce:
"1. Launch gtk3-demo
2. Run the 'Printing' demo
3. Select a printer so that the 'Print' button becomes available
4. Press Shift+Tab to move from the selected printer to the 'General' notebook
tab
5. Press Shift+Tab to move from the 'General' notebook tab to the 'Print'
button.

Expected result: Focus would move to the 'Print' button.

Actual result: Focus skips the action area completely and the 'Reverse'
checkbox gains focus.
6. Press Tab from the 'Reverse' checkbox to give focus to the 'Print' button
7. Press Tab once more to give focus to the 'General' notebook tab
8. Press Shift+Tab to move from the 'General' notebook tab to the 'Print'
button.
This time it works as expected.

It seems that giving focus to something on a notebook page prior to
Shift+Tabbing is what causes the action area to be skipped over."

I searched what commit fixed this issue with upstream level, following commit fixed this issue in GTK+ 3.5.6:
"From 3056324570dc5f0e94a9da0958e4980199200ab6 Mon Sep 17 00:00:00 2001
From: Matthias Clasen <email address hidden>
Date: Sat, 23 Jun 2012 16:20:54 +0000
Subject: GtkNotebook: Fix reverse tab order

When using Shift-Tab to move the focus out of page content onto
the tab label, we end up in a situation where both Tab and Shift-Tab
move focus back into the page, which is not really what is expected
when the notebook is part of a dialog.

Instead, arrange things so that using Shift-Tab with focus on a
tab label moves the focus out of the notebook."

This bug is important with accessibility, if the Ubuntu 12.04 LTS release policy prowide possibility to fix this bug, please fix this issue.

Attila

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: libgtk-3-0 3.4.2-0ubuntu0.4
ProcVersionSignature: Ubuntu 3.2.0-32.51-generic-pae 3.2.30
Uname: Linux 3.2.0-32-generic-pae i686
ApportVersion: 2.0.1-0ubuntu13
Architecture: i386
Date: Thu Oct 4 08:39:15 2012
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Beta i386 (20120327)
SourcePackage: gtk+3.0
UpgradeStatus: No upgrade log present (probably fresh install)

[Attila Hammer (hammera)]

Hope helps fixing this bug Ubuntu level with I doed work:
I follow down upstream GTK+ 3.6 version awailable commits and searched what commit fix this issue in GTK+ 3.5.6 version. I generated a debdiff with Precise awailable gtk+3.0 source package and added proper upstream patch.
We have lucky, because the upstream level 3.5.6 version committed fix compatible with GTK+3.4.2 version.

I risk little, but doed a local build the patched package with my local testing Ubuntu 12.04.1 system, and tested the modified version after installation and restart. Because in Orca screen reader preferences dialog I always experienced this issue prewious when I tryed the wrote testcase, I repeat the testcase the modified installed package. I opened Orca preferences dialog, press tab key, and press two shift+tab key combination. Prewious original GTK 3.4.2 version the focus not land right with OK button, the focus land with speak objects under mouse check box. Now focus right land with OK button, similar with Ubuntu Quantal awailable upstream GTK 3.6.0 version. If I opened prewious original GTK+3.4.2 version the Orca preferences dialog, press TAB key and a shift+TAB key and try switch next page with right arrow key, the page tab switch not happened right, focus land the speak objects under mouse check button. The modified version page tab switch happening right this testcase too.

Sebastien, your openion have chance to land this important fix with Ubuntu 12.04? Ubuntu 12.04 release policy enable to backport this fix with GTK+ 3.4.2 version?
Not only a11y products affecting this fix, normal keyboard navigation working broken with multipage dialogs in GTK+ 3.4.2 if an Ubuntu user using keyboard the navigation and known the description wrote testcase.
Unfortunately GNOME Developers not will be releasing new maintenance release the 3.4 series GNOME components, and this fix land upstream level after end of 3.4 series officialy maintenance cicle.
If the LTS release policy not enable to accept this fix, I full agree this choice.

Attila

[Sebastien Bacher (seb128)]

Thanks Attila, that fix seems indeed worth backporting for the next upload

[Attila Hammer (hammera)]

Thank you Sebastien.
Usual, what schedule time happening upload the GTK+3.0 source package in
Precise repository?
Will be awailable this fix before 12.04.2 release, or enough shorter
time and have a scheduled upload this package related already?

Attila

[Sebastien Bacher (seb128)]

We are pretty busy with quantal at the moment but it should land this month so no problem for 12.04.2

[Attila Hammer (hammera)]

Many thanks Sebastien.

Attila

[Martin Pitt (pitti)]

Sponsored with fixed changelog formatting and bug ref, thanks!

[Clint Byrum (clint-fewbar)]

Hello Attila, or anyone else affected,

Accepted gtk+3.0 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gtk+3.0/3.4.2-0ubuntu0.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Attila Hammer (hammera)]

Hello Clint,

I have got a very good news:
I tested the proposed repository awailable gtk+3.0 related packages my Ubuntu 12.04 systems both GNOME3 3.4 fallback session and Unity 2d. Both two desktop environments the reported bug are resolved after upgrade, I need only logout and login back my account after upgrade.
I prewious wrote testcases now works succesfuly with multipage dialogues, for example Orca Screen Reader after I opening preferences dialog, press a TAB and two SHIFT+TAB key combinations, the caret right land the OK button. If I opening Orca Screen Reader preferences dialog, press a TAB key and one SHIFT+TAB key combination, when I after this key presses press right or left arrow, caret goto next or prewious page tab. Prewious without the upgraded packages this testcases not works with multipage dialogs.
I not experienced any new errors with related this upgrade, upgrade happened without any errors.

Please put this upgraded gtk+3.0 related packages with precise-updates repository.

Attila

[Clint Byrum (clint-fewbar)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+3.0 - 3.4.2-0ubuntu0.5

---------------
gtk+3.0 (3.4.2-0ubuntu0.5) precise-proposed; urgency=low

  * Add debian/patches/gtk-notebook.patch: Fix some keyboard navigation
    breakage with GTK Notebook issue, based with upstream level awailable fix
    in GTK+ 3.5.6. (LP: #1061419)
 -- Attila Hammer <email address hidden> Thu, 04 Oct 2012 09:07:10 +0200