Swatches : Sort the list of swatch names

Bug #1060563 reported by John Smith
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Wishlist
John Smith

Bug Description

Sort the list of swatch names in the popup menu

Tags: color ui swatch
Revision history for this message
John Smith (john-smithi) wrote :

Patch to sort all palettes by name.
The user and system palettes are not separated since it is probably confusing having a "radio list" of palettes with separators in the middle. The other option is to have the user palettes simply listed before the system palettes but not separated.

Changed in inkscape:
assignee: nobody → John Smith (john-smithi)
status: New → In Progress
Revision history for this message
su_v (suv-lp) wrote :

Some notes (without having testing the patch yet):

1) In builds on OS X (backend of GTK+ doesn't matter) the palettes are already sorted by name (local first, system below), unlike e.g. on Ubuntu 12.10 - this seems to be the same difference as was seen with the templates (bug #681625).

2) User vs. shared palettes:
> The other option is to have the user palettes simply listed
> before the system palettes but not separated.

<opinion>/me would prefer to have user templates above shared (system) templates (this is what I see with current stable and trunk).</opinion>

3) Palettes installed to be shared between applications [1]:
There are other paths which are searched for palettes (see e.g. bug #780659, palettes from the create-resources package), and IIRC those found installed by other packages are listed below the the ones that are installed by inkscape itself (with current stable as well as trunk).

4) Palette files suffix:
With current stable and trunk, the suffix of palette files (*.gpl) seems to be ignored (any file found in the searched paths seems to be read, and added if it contains a palette definition) This causes for example automatic backup files of palettes edited with gvim or gedit (*.gpl~) to be included in Inkscape's list unexpectedly. Any chance that at least the most common suffixes for backup files could be excluded, or that only *.gpl files are considered for inclusion?

---
[1] http://en.wikipedia.org/wiki/Create_Project

tags: added: color
Changed in inkscape:
importance: Undecided → Wishlist
Revision history for this message
su_v (suv-lp) wrote :

> ---
> [1] http://en.wikipedia.org/wiki/Create_Project

The wiki of the 'create' project seems to have gone off-line:
<http://web.archive.org/web/20100817183537/http://create.freedesktop.org/wiki/Main_Page>
Mailing list is still active though:
<http://lists.freedesktop.org/archives/create/>

Revision history for this message
John Smith (john-smithi) wrote :

> 1) 2) and 3) Previously there were 3 paths checked for palettes - user/system/"create". Palettes were listed in those groups and (possibly) sorted. Patch v2 groups by user/system only and sorts. "Create" palettes are included and sorted with the system group.

> 4) Palette files suffix:
There is commented out code that checks for files for extension 'gpl'. I wonder if someone requested removing that filtering at some time ? As a small fix have excluded files ending in '~' in this patch.

Revision history for this message
John Smith (john-smithi) wrote :

Committed as r11757.

Changed in inkscape:
status: In Progress → Fix Committed
su_v (suv-lp)
Changed in inkscape:
milestone: none → 0.49
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
Revision history for this message
su_v (suv-lp) wrote :

Follow-up report (regression):
* Bug #1447971 “User palettes not available if all shared system palettes are deleted from installation”
  https://bugs.launchpad.net/inkscape/+bug/1447971

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.