[previews] Track titles aren't escaped
Bug #1039020 reported by
Michal Hruby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Nick Dedekind | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Nick Dedekind |
Bug Description
Tracks with '&' in the titles cause an error with unity:
WARN 2012-08-20 14:56:22 unity.pango <unknown>:0 pango_layout_
I think it's safer if unity escapes the string and doesn't except the lenses to do it. (this basically applies to all preview fields except description which should allow markup).
Related branches
lp:~nick-dedekind/unity/lp1039020.preview-text-escape
- Andrea Azzarone (community): Approve
- Sam Spilsbury (community): Approve
-
Diff: 424 lines (+71/-54)14 files modifieddash/previews/ActionButton.cpp (+1/-1)
dash/previews/ApplicationPreview.cpp (+7/-8)
dash/previews/GenericPreview.cpp (+3/-4)
dash/previews/MoviePreview.cpp (+3/-4)
dash/previews/MusicPreview.cpp (+2/-2)
dash/previews/PreviewInfoHintWidget.cpp (+2/-2)
dash/previews/PreviewRatingsWidget.cpp (+1/-1)
dash/previews/Track.cpp (+1/-1)
tests/test_previews_application.cpp (+10/-10)
tests/test_previews_generic.cpp (+6/-6)
tests/test_previews_movie.cpp (+6/-6)
tests/test_previews_music.cpp (+5/-5)
unity-shared/StaticCairoText.cpp (+20/-3)
unity-shared/StaticCairoText.h (+4/-1)
lp:~sil2100/unity/ubuntu_ffe1
(Merged)
Changed in unity: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
milestone: | none → 6.4 |
summary: |
- [previews] Track title aren't escaped + [previews] Track titles aren't escaped |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
importance: | Undecided → Medium |
status: | New → Fix Committed |
Changed in unity: | |
milestone: | 6.6 → 7.0 |
no longer affects: | unity/6.0 |
Changed in unity: | |
milestone: | 7.0 → 6.6 |
Changed in unity: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Update: Unity 6.4 is revision 2632, so this is actually fix committed for Unity 6.6.