Window management - Display full size window decorations on currently selected window in spread

Bug #1033935 reported by Ugo Riboni
52
This bug affects 11 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
High
John Lea
Unity
Fix Released
High
Renato Araujo Oliveira Filho
unity (Ubuntu)
Fix Released
High
Unassigned

Bug Description

According to the updated design document for Unity: "The currently focused window is highlighted, with an orange glow outline and a full-size title bar, clearly showing the window caption and providing access to a close button. If there is not enough space to display the window caption, it is displayed just below the title bar"

See http://design.canonical.com/the-toolkit/unity-task-switching/.

Related branches

John Lea (johnlea)
summary: - Display full size window decorations on currently selected window in
- spread
+ Window management - Display full size window decorations on currently
+ selected window in spread
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → High
Changed in unity:
importance: Undecided → High
Changed in unity (Ubuntu):
importance: Undecided → High
Changed in ayatana-design:
status: New → Triaged
Changed in unity:
status: New → Triaged
Changed in unity (Ubuntu):
status: New → Triaged
Changed in unity:
milestone: none → backlog
tags: added: udp
Olivier Tilloy (osomon)
description: updated
Changed in unity:
assignee: nobody → Ugo Riboni (uriboni)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Difficulty: Very Difficult, would not recommend this cycle
Method:
1) Make the decor plugin an interface plugin (like scale, cube, etc)
2) Make DecorWindow::glDecorate a wrappable function
3) Overload it unity side
4) On UnityWindow::glDecorate, draw the decoration texture using GLWindow::glDrawTexture but the "region" should be the size of the scale slot instead of the actual window size (this will probably make it draw at full size, not sure).
Test: Not sure at this point. This may require a bit of 2D matrix manipulation and that will definitely need testing.

Ugo Riboni (uriboni)
Changed in unity:
assignee: Ugo Riboni (uriboni) → nobody
John Lea (johnlea)
Changed in ayatana-design:
status: Triaged → Fix Committed
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

The main issue of this bug (the decorations) has been fixed, please open a new bug for the glow effect (currently missing)

Changed in unity:
assignee: nobody → Renato Araujo Oliveira Filho (renatofilho)
status: Triaged → Fix Committed
Changed in unity (Ubuntu):
status: Triaged → Fix Committed
Tim Penhey (thumper)
Changed in unity:
milestone: backlog → none
Tim Penhey (thumper)
tags: added: exbacklog
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (9.2 KiB)

This bug was fixed in the package unity - 6.6.0-0ubuntu1

---------------
unity (6.6.0-0ubuntu1) quantal-proposed; urgency=low

  * New upstream release.
    - Fixes non-escaped character sequences in dash previews (LP: #1039020)
    - Updated background layer for preview cover-art and details panels
      to be 10% low-light
    - Expand a PlacesGroup if it is the only category that contains results
      (LP: #950710)
    - Update unity autopilot tests to match autopilot API
    - Updated the convert files to fix some typos in the key names
    - Add gmodule dependency
    - Activate proper result if the categories aren't displayed in-order
      (LP: #1040101)
    - Refactor device launcher icons (LP: #713423)
    - LauncherController: make the controller enable the launcher struts,
      based on hide-mode option (LP: #1044005)
    - Launcher: make always possible to drag an icon to the bottom or top
      of its sub list (LP: #1043968)
    - Don't desat bfb/hud icon in DNDReset (LP: #1043963)
    - Progressively adjust the speed of the minimize animation. First
      time it is used is slower, then speeds up the more it is used.
      (LP: #1017510)
    - Implement new ordering of categories for home lens. (LP: #1043915)
    - UnityWindow now implements ScaleWindowInterface (LP: #876017)
    - Launcher: restore an icon position after that the dragging has been
      cancelled (LP: #955561)
    - LauncherDragWindow: cancel drag on window mapped/unmapped
      (LP: #1044723)
    - Now there is a check of an override color in RefreshColor (which is
      called when a PropertyNotify event happens). Also added a check in
      FullySaturateColor to a void division by zero. (LP: #975350)
    - Queue redraw after cover-art texture is updated from a url/file source.
      (LP: #1043947)
    - Fixed ability to delete glib::Source wrapper during its callback
      (LP: #1044823)
    - Close preview when dash is hidden. (LP: #1045298)
    - LauncherModel: rewrite the Reordering functions to keep the icon
      priority deltas (LP: #761155)
    - Make sure we can pass extra hints when activating preview actions.
      (LP: #1046352)
    - UnityWindow: scale window code improved (LP: #1033935)
    - The mouse will now cause the HUD buttons to change selection
      (LP: #1042692)
    - "Alt+Space" shortcut to reveal the window menu is not hardcoded, but a
       Compiz key option. " (Hold)" should also be translated. Made all
       Compiz plug-in names and all Compiz plug-in option names in
       unityshell.cpp static constants.
    - remove unity --reset, it's not anymore really needed now that we are
      in stable days of unity and we moved to gsettings
    - Removed the variables 'oldPrev' and 'oldNext' which got assigned the
      value NULL, but then were never used
    - Fixed the size of the previews to 770x380 pixels. (LP: #1045243)
    - UnityWindow: use smart pointers, use static close_icon (with dynamic
      state) and PanelStyle context (LP: #1033935) (LP: #1045127)
      (LP: #1046124) (LP: #1046126)
    - Remove everything in the #ifndef USE_MODERN_COMPIZ_GL ifdefs and remove
      the ifdefs alltogether. unity now requires compiz...

Read more...

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Changed in ayatana-design:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released
tags: added: reviewedbydesignq
removed: udp
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.