prefix field in the wrong place in patron registration

Bug #1019855 reported by Ben Shum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.1
Fix Released
Low
Unassigned
2.2
Fix Released
Low
Unassigned

Bug Description

Evergreen 2.0+

When the prefix field was added back as part of work done for LP 923872 (https://bugs.launchpad.net/evergreen/+bug/923872), it was placed after the first/middle name and before the last name.

Ideally, this should have been before the first name of the patron.

Also, the label should have been "Prefix/Title" and the "Title" part removed from the "Suffix/Title" field.

Branch to try correcting this at: user/bshum/move-patron-prefix

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/move-patron-prefix

Tags: pullrequest
Revision history for this message
James Fournie (jfournie) wrote :

Ben you beat me to the fix!

Signed off if it helps

working/user/jamesrf/lp1019855

Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.3.0-alpha2
status: New → Confirmed
Revision history for this message
Dan Scott (denials) wrote :

Committed to master, as well as rel_2_2 and rel_2_1. In the stable releases, I added the following note to the commit message:

"""
    Note: string changes would normally not be allowed in a stable release,
    however in this case the previous translation (if any) will still get
    pulled from the IDL for the field in question, so English will not
    suddenly start showing up in the patron registration form.
"""

Thanks Ben & James!

Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Michael Peters (mrpeters) wrote :

My bad on the wrong location, guys. Sorry.

I had fixed it in my production and never thought to share it.

The real annoying thing is the way it displays in the top left:

Mr. Peters, Michael

Seems funny, doesn't it?

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.