resize leave leftover libvirt configs

Bug #1015731 reported by Yun Mao
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Jian Wen
Folsom
Fix Released
Medium
Chuck Short
nova (Ubuntu)
Fix Released
Undecided
Unassigned
Quantal
Fix Released
Undecided
Unassigned

Bug Description

How to reproduce:

1) create an instance, note the physical host as src_host where the VM is created
2) nova resize servername $flavor
...wait a long time for it to finish
3) nova resize-confirm servername

now login to the source node of the src_host, do virsh list --all
the instance should still be there listed as shutoff, which should in theory no longer exist.

Revision history for this message
Vish Ishaya (vishvananda) wrote :

looks like confirm_migration needs a self.destroy(instance, network_info)
after the self._cleanup_resize()

Changed in nova:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Vish Ishaya (vishvananda) wrote :

Although we probably need a check to make sure that we haven't resized to the same host before doing so. I don't see anything in the current code base that is doing so.

Revision history for this message
Zap Chang (zapchang) wrote :

iptable rules for instance last on the source node, too.
Once the instance is deleted, the rule on source node is not clean, which makes later instance with the same fixed IP might not be reached via floating IP. Because security group rule of the first instance is applied first.

Revision history for this message
Jian Wen (wenjianhn) wrote :

Hi, zap.

I reprouduced it.
I will see if I can do something.

Revision history for this message
Jian Wen (wenjianhn) wrote :
Jian Wen (wenjianhn)
Changed in nova:
assignee: nobody → Sina Web Service Dev (sws)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13615

Changed in nova:
assignee: Sina Web Service Dev (sws) → Jian Wen (wenjianhn)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/13615
Committed: http://github.com/openstack/nova/commit/d272415fd6fe9cdbd66fdfdf9aedc8a43b87d9b5
Submitter: Jenkins
Branch: master

commit d272415fd6fe9cdbd66fdfdf9aedc8a43b87d9b5
Author: Jian Wen <email address hidden>
Date: Mon Sep 24 23:30:02 2012 +0800

    libvirt: Fix _cleanup_resize

    Undefine domain and unplug vifs in _cleanup_resize if the instance was
    migrated to another host.

    Fixes bug 1015731

    Change-Id: If6eb1ada029d462777bbd6ea113c98c3b801cf5d

Changed in nova:
status: In Progress → Fix Committed
tags: added: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/14764

Chuck Short (zulcss)
tags: removed: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/14764
Committed: http://github.com/openstack/nova/commit/fb888279561201e85c461ae3c1450504f049c22c
Submitter: Jenkins
Branch: stable/folsom

commit fb888279561201e85c461ae3c1450504f049c22c
Author: Jian Wen <email address hidden>
Date: Mon Sep 24 23:30:02 2012 +0800

    libvirt: Fix _cleanup_resize

    Undefine domain and unplug vifs in _cleanup_resize if the instance was
    migrated to another host.

    Fixes bug 1015731

    Change-Id: If6eb1ada029d462777bbd6ea113c98c3b801cf5d
    (cherry picked from commit d272415fd6fe9cdbd66fdfdf9aedc8a43b87d9b5)

Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Changed in nova (Ubuntu):
status: New → Fix Released
Changed in nova (Ubuntu Quantal):
status: New → Confirmed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Yun, or anyone else affected,

Accepted nova into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nova/2012.2.1+stable-20121212-a99a802e-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nova (Ubuntu Quantal):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Jian Wen (wenjianhn) wrote :

I will do it on Monday next week.

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (8.3 KiB)

This bug was fixed in the package nova - 2012.2.1+stable-20121212-a99a802e-0ubuntu1

---------------
nova (2012.2.1+stable-20121212-a99a802e-0ubuntu1) quantal-proposed; urgency=low

  * Ubuntu updates:
    - debian/control: Ensure novaclient is upgraded with nova,
      require python-keystoneclient >= 1:2.9.0. (LP: #1073289)
    - d/p/avoid_setuptools_git_dependency.patch: Refresh.
  * Dropped patches, applied upstream:
    - debian/patches/CVE-2012-5625.patch: [a99a802]
  * Resynchronize with stable/folsom (b55014ca) (LP: #1085255):
    - [a99a802] create_lvm_image allocates dirty blocks (LP: #1070539)
    - [670b388] RPC exchange name defaults to 'openstack' (LP: #1083944)
    - [3ede373] disassociate_floating_ip with multi_host=True fails
      (LP: #1074437)
    - [22d7c3b] libvirt imagecache should handle shared image storage
      (LP: #1075018)
    - [e787786] Detached and deleted RBD volumes remain associated with insance
      (LP: #1083818)
    - [9265eb0] live_migration missing migrate_data parameter in Hyper-V driver
      (LP: #1066513)
    - [3d99848] use_single_default_gateway does not function correctly
      (LP: #1075859)
    - [65a2d0a] resize does not migrate DHCP host information (LP: #1065440)
    - [102c76b] Nova backup image fails (LP: #1065053)
    - [48a3521] Fix config-file overrides for nova-dhcpbridge
    - [69663ee] Cloudpipe in Folsom: no such option: cnt_vpn_clients
      (LP: #1069573)
    - [6e47cc8] DisassociateAddress can cause Internal Server Error
      (LP: #1080406)
    - [22c3d7b] API calls to dis-associate an auto-assigned floating IP should
      return proper warning (LP: #1061499)
    - [bd11d15] libvirt: if exception raised during volume_detach, volume state
      is inconsistent (LP: #1057756)
    - [dcb59c3] admin can't describe all images in ec2 api (LP: #1070138)
    - [78de622] Incorrect Exception raised during Create server when metadata
      over 255 characters (LP: #1004007)
    - [c313de4] Fixed IP isn't released before updating DHCP host file
      (LP: #1078718)
    - [f4ab42d] Enabling Return Reservation ID with XML create server request
      returns no body (LP: #1061124)
    - [3db2a38] 'BackupCreate' should accept rotation parameter greater than or
      equal to zero (LP: #1071168)
    - [f7e5dde] libvirt reboot sometimes fails to reattach volumes
      (LP: #1073720)
    - [ff776d4] libvirt: detaching volume may fail while terminating other
      instances on the same host concurrently (LP: #1060836)
    - [85a8bc2] Used instance uuid rather than id in remove-fixed-ip
    - [42a85c0] Fix error on invalid delete_on_termination value
    - [6a17579] xenapi migrations fail w/ swap (LP: #1064083)
    - [97649b8] attach-time field for volumes is not updated for detach volume
      (LP: #1056122)
    - [8f6a718] libvirt: rebuild is not using kernel and ramdisk associated with
      the new image (LP: #1060925)
    - [fbe835f] live-migration and volume host assignement (LP: #1066887)
    - [c2a9150] typo prevents volume_tmp_dir flag from working (LP: #1071536)
    - [93efa21] Instances deleted during spawn leak network allocations
      (LP: #1068716)
    - [ebabd02] After restartin...

Read more...

Changed in nova (Ubuntu Quantal):
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.