API calls to dis-associate an auto-assigned floating IP should return proper warning

Bug #1061499 reported by Sirisha Devineni
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Sirisha Devineni
Folsom
Fix Released
Medium
Vish Ishaya
nova (Ubuntu)
Fix Released
Undecided
Unassigned
Quantal
Fix Released
Undecided
Unassigned

Bug Description

Currently if a user attempts to disassociate a public IP address which has been auto_assigned the request is accepted but silently ignored.
$nova list
+--------------------------------------+------+--------+--------------------------------+
| ID | Name | Status | Networks |
+--------------------------------------+------+--------+--------------------------------+
| e8615e1c-cf8d-4136-ba8c-2ba14d99853d | srv8 | ACTIVE | private=10.0.0.3, 172.24.4.225 |
+--------------------------------------+------+--------+--------------------------------+
Here 172.24.4.225 is an auto assigned floating IP.
root@ubuntu28folsom:~/launchpad_nova/nova# nova remove-floating-ip e8615e1c-cf8d-4136-ba8c-2ba14d99853d 172.24.4.225
$nova list
+--------------------------------------+------+--------+--------------------------------+
| ID | Name | Status | Networks |
+--------------------------------------+------+--------+--------------------------------+
| e8615e1c-cf8d-4136-ba8c-2ba14d99853d | srv8 | ACTIVE | private=10.0.0.3, 172.24.4.225 |
+--------------------------------------+------+--------+--------------------------------+

If I try to disassociate the auto assigned public address it fails - which is fine - but it does so it a silent way i.e. it gives no hint that the requested operation is not allowed, and that it will not be executed. If a message like "Can't disassociate auto assigned floating IP" can be thrown then that will be helpful to the end user.

Changed in nova:
assignee: nobody → Sirisha Devineni (sirisha-devineni)
Revision history for this message
Dan Prince (dan-prince) wrote :

Fixing the return code and error message sounds like a fine fix for now and if fits in well with the Nova's current implementation of floating IPs.

Long term I'd like to consider treating auto-assigned floating IPs just like we do normal IPs and allow them to be unassigned. This is perhaps more invasive however and we'd have to look into a mechanism to safely deprecate the current behavor.

Changed in nova:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14157

Changed in nova:
status: Triaged → In Progress
tags: added: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/14157
Committed: http://github.com/openstack/nova/commit/ce04b13f26169e2d71b7d3122d3a769cb4348bf7
Submitter: Jenkins
Branch: master

commit ce04b13f26169e2d71b7d3122d3a769cb4348bf7
Author: Sirisha Devineni <email address hidden>
Date: Mon Oct 8 19:39:15 2012 +0530

    Dis-associate an auto-assigned floating IP should return proper warning

    Added new exception class CannotDissociateAutoAssignedFloatingIP and raised
    exception instead of return.

    Fixes bug 1061499

    Change-Id: I348573a235c6b81653837267072b5c48fa15b8af

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
tags: removed: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/16660

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/16660
Committed: http://github.com/openstack/nova/commit/22c3d7b323773fe549d84f08d195c641c85d16b7
Submitter: Jenkins
Branch: stable/folsom

commit 22c3d7b323773fe549d84f08d195c641c85d16b7
Author: Sirisha Devineni <email address hidden>
Date: Mon Oct 8 19:39:15 2012 +0530

    Dis-associate an auto-assigned floating IP should return proper warning

    Added new exception class CannotDissociateAutoAssignedFloatingIP and raised
    exception instead of return.

    Fixes bug 1061499

    Change-Id: I348573a235c6b81653837267072b5c48fa15b8af
    (cherry picked from commit ce04b13f26169e2d71b7d3122d3a769cb4348bf7)

Changed in nova (Ubuntu):
status: New → Fix Released
Changed in nova (Ubuntu Quantal):
status: New → Confirmed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Sirisha, or anyone else affected,

Accepted nova into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nova/2012.2.1+stable-20121212-a99a802e-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nova (Ubuntu Quantal):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (8.3 KiB)

This bug was fixed in the package nova - 2012.2.1+stable-20121212-a99a802e-0ubuntu1

---------------
nova (2012.2.1+stable-20121212-a99a802e-0ubuntu1) quantal-proposed; urgency=low

  * Ubuntu updates:
    - debian/control: Ensure novaclient is upgraded with nova,
      require python-keystoneclient >= 1:2.9.0. (LP: #1073289)
    - d/p/avoid_setuptools_git_dependency.patch: Refresh.
  * Dropped patches, applied upstream:
    - debian/patches/CVE-2012-5625.patch: [a99a802]
  * Resynchronize with stable/folsom (b55014ca) (LP: #1085255):
    - [a99a802] create_lvm_image allocates dirty blocks (LP: #1070539)
    - [670b388] RPC exchange name defaults to 'openstack' (LP: #1083944)
    - [3ede373] disassociate_floating_ip with multi_host=True fails
      (LP: #1074437)
    - [22d7c3b] libvirt imagecache should handle shared image storage
      (LP: #1075018)
    - [e787786] Detached and deleted RBD volumes remain associated with insance
      (LP: #1083818)
    - [9265eb0] live_migration missing migrate_data parameter in Hyper-V driver
      (LP: #1066513)
    - [3d99848] use_single_default_gateway does not function correctly
      (LP: #1075859)
    - [65a2d0a] resize does not migrate DHCP host information (LP: #1065440)
    - [102c76b] Nova backup image fails (LP: #1065053)
    - [48a3521] Fix config-file overrides for nova-dhcpbridge
    - [69663ee] Cloudpipe in Folsom: no such option: cnt_vpn_clients
      (LP: #1069573)
    - [6e47cc8] DisassociateAddress can cause Internal Server Error
      (LP: #1080406)
    - [22c3d7b] API calls to dis-associate an auto-assigned floating IP should
      return proper warning (LP: #1061499)
    - [bd11d15] libvirt: if exception raised during volume_detach, volume state
      is inconsistent (LP: #1057756)
    - [dcb59c3] admin can't describe all images in ec2 api (LP: #1070138)
    - [78de622] Incorrect Exception raised during Create server when metadata
      over 255 characters (LP: #1004007)
    - [c313de4] Fixed IP isn't released before updating DHCP host file
      (LP: #1078718)
    - [f4ab42d] Enabling Return Reservation ID with XML create server request
      returns no body (LP: #1061124)
    - [3db2a38] 'BackupCreate' should accept rotation parameter greater than or
      equal to zero (LP: #1071168)
    - [f7e5dde] libvirt reboot sometimes fails to reattach volumes
      (LP: #1073720)
    - [ff776d4] libvirt: detaching volume may fail while terminating other
      instances on the same host concurrently (LP: #1060836)
    - [85a8bc2] Used instance uuid rather than id in remove-fixed-ip
    - [42a85c0] Fix error on invalid delete_on_termination value
    - [6a17579] xenapi migrations fail w/ swap (LP: #1064083)
    - [97649b8] attach-time field for volumes is not updated for detach volume
      (LP: #1056122)
    - [8f6a718] libvirt: rebuild is not using kernel and ramdisk associated with
      the new image (LP: #1060925)
    - [fbe835f] live-migration and volume host assignement (LP: #1066887)
    - [c2a9150] typo prevents volume_tmp_dir flag from working (LP: #1071536)
    - [93efa21] Instances deleted during spawn leak network allocations
      (LP: #1068716)
    - [ebabd02] After restartin...

Read more...

Changed in nova (Ubuntu Quantal):
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.