Oh right, I missed that uninstallability etc. also sets is_valid to False.
> It feels like a case of "why not do this refactoring while you're there?" that would put someone off implementing the fix to the actual issue.
Yes, that was it.
So indeed just adding the current verdict into Excuse in addition seems fine -- the email policy should then be able to check for something like
if not excuse.is_valid and excuse.current_verdict == PolicyVerdict.REJECTED_PERMANENTLY: do_spam()
?
Oh right, I missed that uninstallability etc. also sets is_valid to False.
> It feels like a case of "why not do this refactoring while you're there?" that would put someone off implementing the fix to the actual issue.
Yes, that was it.
So indeed just adding the current verdict into Excuse in addition seems fine -- the email policy should then be able to check for something like
if not excuse.is_valid and excuse. current_ verdict == PolicyVerdict. REJECTED_ PERMANENTLY:
do_spam()
?