email policy sends email when package is REJECTED_TEMPORARILY
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
britney |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Policies can reject excuses temporarily or permanently. In the temporary case, it is expected that sooner or later the excuse will either become a PASS or REJECTED_
Consider the case where the autopkgtest infrastructure is down or has a large backlog. It could be that tests take more than 1 day to all run for a particular excuse but AFAICS we'll still email the uploaders in that case even though they can't fix it.
If an excuse has current verdict REJECTED_
The problem is that the current verdict isn't available to policies. I can imagine that you could fix this by either changing the policy API to include the current verdict, or by adding the current verdict as an attribute to the excuse. Either of these I would imagine could be proposed / discussed / merged upstream first.
Related branches
- Iain Lane: Approve
- Adam Conrad: Pending requested
-
Diff: 204 lines (+82/-27)2 files modifiedbritney2/policies/email.py (+55/-24)
tests/test_email.py (+27/-3)
I thought this was the whole point of having a dynamic max_age. We can't inspect TEMPORARY vs PERMANENTLY directly, but if it's is_valid we wait until 5 days before sending a mail, that gives more time for long-running autopkgtests.