Dash, multi-monitor: Dash is not dismissed when something in the other display is clicked
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Ayatana Design |
Critical
|
Stewart Wilson | ||
| Unity |
Fix Released
|
Critical
|
Nick Dedekind | |
| unity (Ubuntu) |
Critical
|
Nick Dedekind |
Bug Description
Setup:
Laptop with an external monitor attached: laptop display on the left, Launcher on the laptop display.
Steps to replicate:
Launch a web browser and drag the browser window across to the external display.
Launch the Dash on the laptop display. The Dash is displayed and the Search box takes keyboard focus.
Try to click in the URL bar of the browser window on the external display.
At this point the Dash should have been dismissed, the browser window should have been focused and the URL bar should take keyboard focus. Instead, the Dash remains visible and keeps window and keyboard focus.
Solution:
The Dash should be dismissed when anything is clicked in another display. This click should be actioned immediately by any control it targets.
Related branches
- Brandon Schaefer (community): Approve on 2012-09-12
- Christopher Lee (community): Needs Fixing on 2012-09-11
- Andrea Azzarone (community): Needs Fixing on 2012-09-11
-
Diff: 367 lines (+144/-50)8 files modifieddash/DashController.cpp (+8/-10)
dash/DashController.h (+2/-1)
launcher/LauncherController.cpp (+1/-1)
manual-tests/Dash.txt (+13/-0)
plugins/unityshell/src/unityshell.cpp (+13/-4)
plugins/unityshell/src/unityshell.h (+1/-1)
tests/autopilot/unity/tests/test_dash.py (+55/-17)
tests/autopilot/unity/tests/test_hud.py (+51/-16)
description: | updated |
Changed in unity: | |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in ayatana-design: | |
assignee: | nobody → Stewart Wilson (stewartw) |
Changed in unity: | |
milestone: | none → backlog |
tags: | added: top5p |
Changed in ayatana-design: | |
importance: | Critical → High |
importance: | High → Critical |
Changed in unity: | |
assignee: | nobody → Gord Allott (gordallott) |
Changed in unity: | |
assignee: | Gord Allott (gordallott) → Andrea Azzarone (andyrock) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
status: | In Progress → Triaged |
Changed in unity (Ubuntu): | |
status: | In Progress → Confirmed |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
tags: | added: dashm |
Changed in unity: | |
importance: | High → Critical |
Changed in unity (Ubuntu): | |
importance: | High → Critical |
Changed in unity: | |
assignee: | Andrea Azzarone (andyrock) → Brandon Schaefer (brandontschaefer) |
Changed in unity (Ubuntu): | |
assignee: | Andrea Azzarone (andyrock) → Brandon Schaefer (brandontschaefer) |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
assignee: | Brandon Schaefer (brandontschaefer) → Nick Dedekind (nick-dedekind) |
Changed in unity (Ubuntu): | |
assignee: | Brandon Schaefer (brandontschaefer) → nobody |
Changed in unity (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
Changed in unity: | |
milestone: | backlog → 6.6 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
security vulnerability: | no → yes |
Changed in unity: | |
milestone: | 6.6 → 7.0 |
no longer affects: | unity/6.0 |
Changed in unity: | |
milestone: | 7.0 → 6.6 |
Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package unity - 6.6.0-0ubuntu1
---------------
unity (6.6.0-0ubuntu1) quantal-proposed; urgency=low
* New upstream release.
- Fixes non-escaped character sequences in dash previews (LP: #1039020)
- Updated background layer for preview cover-art and details panels
to be 10% low-light
- Expand a PlacesGroup if it is the only category that contains results
(LP: #950710)
- Update unity autopilot tests to match autopilot API
- Updated the convert files to fix some typos in the key names
- Add gmodule dependency
- Activate proper result if the categories aren't displayed in-order
(LP: #1040101)
- Refactor device launcher icons (LP: #713423)
- LauncherController: make the controller enable the launcher struts,
based on hide-mode option (LP: #1044005)
- Launcher: make always possible to drag an icon to the bottom or top
of its sub list (LP: #1043968)
- Don't desat bfb/hud icon in DNDReset (LP: #1043963)
- Progressively adjust the speed of the minimize animation. First
time it is used is slower, then speeds up the more it is used.
(LP: #1017510)
- Implement new ordering of categories for home lens. (LP: #1043915)
- UnityWindow now implements ScaleWindowInte
- Launcher: restore an icon position after that the dragging has been
cancelled (LP: #955561)
- LauncherDragWindow: cancel drag on window mapped/unmapped
(LP: #1044723)
- Now there is a check of an override color in RefreshColor (which is
called when a PropertyNotify event happens). Also added a check in
FullySatu
- Queue redraw after cover-art texture is updated from a url/file source.
(LP: #1043947)
- Fixed ability to delete glib::Source wrapper during its callback
(LP: #1044823)
- Close preview when dash is hidden. (LP: #1045298)
- LauncherModel: rewrite the Reordering functions to keep the icon
priority deltas (LP: #761155)
- Make sure we can pass extra hints when activating preview actions.
(LP: #1046352)
- UnityWindow: scale window code improved (LP: #1033935)
- The mouse will now cause the HUD buttons to change selection
(LP: #1042692)
- "Alt+Space" shortcut to reveal the window menu is not hardcoded, but a
Compiz key option. " (Hold)" should also be translated. Made all
Compiz plug-in names and all Compiz plug-in option names in
- remove unity --reset, it's not anymore really needed now that we are
in stable days of unity and we moved to gsettings
- Removed the variables 'oldPrev' and 'oldNext' which got assigned the
value NULL, but then were never used
- Fixed the size of the previews to 770x380 pixels. (LP: #1045243)
- UnityWindow: use smart pointers, use static close_icon (with dynamic
state) and PanelStyle context (LP: #1033935) (LP: #1045127)
(LP: #1046124) (LP: #1046126)
- Remove everything in the #ifndef USE_MODERN_
the ifdefs alltogether. unity now requires compiz...
Changed in unity (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignq removed: udp |
We appreciate the difficulties you are facing, but this appears to be a "regular" (non-security) bug. I have unmarked it as a security issue since this bug does not show evidence of allowing attackers to cross privilege boundaries nor directly cause loss of data/privacy.