[FFE] All launcher icons should be moveable except trash and BFB
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
High
|
John Lea | ||
Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
unity-2d |
Invalid
|
Wishlist
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
== CHANGE ==
The Workspace Switcher icon in the Unity bar cannot be moved. Icons below the Workspace icon can be rearranged but not move above the Workspace icon. Additionally, icons above the Workspace icon can be rearranged, but not moved below the Workspace icon. This limits customization of the unity bar.
Desired solution:
- A user should be able to re-order all launcher icons other than the Trash and the BFB to any other location on the Launcher. This includes Workspaces, individual Dash Lenses, and removable storage icons.
- A user should be able to remove both the Workspace icon and the Dash Lens icons from the Launcher. However the Trash and BFB can never be removed from the Launcher.
== TESTING ==
The new functionality is covered by unit tests and manual tests.
== WHY? ==
The design specifications define this behavior since long, but this was never actually introduced in code. It is also a very intuitive behavior. Besides this, the introduced change does not change the existing functionality in any way that could confuse users, since all existing rules applying up until now are still valid. It is just an enhancement.
Original description:
The Workspace Switcher icon in the Unity bar cannot be moved. Icons below the Workspace icon can be rearranged but not move above the Workspace icon. Additionally, icons above the Workspace icon can be rearranged, but not moved below the Workspace icon. This limits customization of the unity bar.
Desired solution:
- A user should be able to re-order all launcher icons other than the Trash and the BFB to any other location on the Launcher. This includes Workspaces, individual Dash Lenses, and removable storage icons.
- A user should be able to remove both the Workspace icon and the Dash Lens icons from the Launcher. However the Trash and BFB can never be removed from the Launcher.
- Both the workspace icon and the Dash Lenses should be accessible via the Dash App Lens. A user must be able to search for say "Workspaces" in the Dash and then drag and drop the Workspaces icon back into the launcher.
Related branches
- Andrea Azzarone (community): Approve
- Brandon Schaefer (community): Approve
-
Diff: 7548 lines (+3855/-1096)72 files modifiedUnityCore/DesktopUtilities.cpp (+29/-9)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+0/-4)
com.canonical.Unity.gschema.xml (+3/-3)
launcher/AbstractLauncherIcon.h (+16/-2)
launcher/BFBLauncherIcon.cpp (+1/-0)
launcher/BamfLauncherIcon.cpp (+31/-48)
launcher/BamfLauncherIcon.h (+0/-1)
launcher/CMakeLists.txt (+1/-0)
launcher/DesktopLauncherIcon.cpp (+19/-6)
launcher/DesktopLauncherIcon.h (+4/-12)
launcher/DeviceLauncherSection.cpp (+14/-7)
launcher/DeviceLauncherSection.h (+3/-5)
launcher/DndData.cpp (+5/-5)
launcher/DndData.h (+1/-1)
launcher/ExpoLauncherIcon.cpp (+64/-0)
launcher/ExpoLauncherIcon.h (+45/-0)
launcher/FavoriteStore.cpp (+93/-4)
launcher/FavoriteStore.h (+21/-8)
launcher/FavoriteStoreGSettings.cpp (+67/-68)
launcher/FavoriteStoreGSettings.h (+7/-4)
launcher/FavoriteStorePrivate.cpp (+14/-0)
launcher/FavoriteStorePrivate.h (+3/-1)
launcher/HudLauncherIcon.cpp (+2/-1)
launcher/Launcher.cpp (+82/-108)
launcher/Launcher.h (+5/-8)
launcher/LauncherController.cpp (+526/-341)
launcher/LauncherController.h (+1/-3)
launcher/LauncherControllerPrivate.h (+28/-41)
launcher/LauncherIcon.cpp (+31/-4)
launcher/LauncherIcon.h (+5/-9)
launcher/LauncherModel.cpp (+34/-32)
launcher/MockLauncherIcon.h (+11/-15)
launcher/SoftwareCenterLauncherIcon.cpp (+27/-38)
launcher/SoftwareCenterLauncherIcon.h (+1/-1)
launcher/SpacerLauncherIcon.cpp (+1/-1)
launcher/SpacerLauncherIcon.h (+0/-4)
launcher/StandaloneLauncher.cpp (+1/-1)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+34/-4)
launcher/VolumeLauncherIcon.h (+3/-0)
manual-tests/Launcher.txt (+15/-0)
panel/PanelMenuView.h (+0/-1)
plugins/unityshell/src/unityshell.cpp (+5/-7)
plugins/unityshell/unityshell.xml.in (+0/-6)
tests/CMakeLists.txt (+19/-11)
tests/gmockvolume.c (+3/-2)
tests/test_bamf_launcher_icon.cpp (+70/-2)
tests/test_bfb_launcher_icon.cpp (+11/-8)
tests/test_desktop_launcher_icon.cpp (+80/-0)
tests/test_desktop_utilities.cpp (+52/-22)
tests/test_device_launcher_section.cpp (+19/-54)
tests/test_expo_launcher_icon.cpp (+58/-0)
tests/test_favorite_store.cpp (+111/-0)
tests/test_favorite_store_gsettings.cpp (+52/-29)
tests/test_hud_launcher_icon.cpp (+53/-0)
tests/test_launcher.cpp (+226/-15)
tests/test_launcher_controller.cpp (+1246/-44)
tests/test_launcher_icon.cpp (+113/-0)
tests/test_launcher_model.cpp (+182/-40)
tests/test_main.cpp (+1/-0)
tests/test_main_xless.cpp (+1/-1)
tests/test_mock_devices.h (+93/-0)
tests/test_software_center_launcher_icon.cpp (+74/-0)
tests/test_trash_launcher_icon.cpp (+39/-0)
tests/test_volume_launcher_icon.cpp (+67/-46)
unity-shared/PluginAdapter.h (+2/-0)
unity-shared/PluginAdapterCompiz.cpp (+5/-0)
unity-shared/PluginAdapterStandalone.cpp (+15/-7)
unity-shared/WindowManager.cpp (+5/-0)
unity-shared/WindowManager.h (+1/-0)
unity-standalone/StandaloneUnity.cpp (+2/-2)
- Andrea Azzarone (community): Approve
- jenkins: Pending (continuous-integration) requested
-
Diff: 1314 lines (+513/-454)7 files modifiedlauncher/Launcher.cpp (+2/-1)
launcher/LauncherController.cpp (+1/-6)
launcher/LauncherModel.cpp (+191/-202)
launcher/LauncherModel.h (+19/-20)
launcher/MockLauncherIcon.h (+9/-9)
tests/test_launcher.cpp (+0/-4)
tests/test_launcher_model.cpp (+291/-212)
- Andrea Azzarone (community): Approve
- Brandon Schaefer (community): Approve
-
Diff: 7558 lines (+3857/-1097)72 files modifiedUnityCore/DesktopUtilities.cpp (+29/-9)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+0/-4)
com.canonical.Unity.gschema.xml (+3/-3)
launcher/AbstractLauncherIcon.h (+16/-2)
launcher/BFBLauncherIcon.cpp (+1/-0)
launcher/BamfLauncherIcon.cpp (+31/-48)
launcher/BamfLauncherIcon.h (+0/-1)
launcher/CMakeLists.txt (+1/-0)
launcher/DesktopLauncherIcon.cpp (+19/-6)
launcher/DesktopLauncherIcon.h (+4/-12)
launcher/DeviceLauncherSection.cpp (+14/-7)
launcher/DeviceLauncherSection.h (+3/-5)
launcher/DndData.cpp (+5/-5)
launcher/DndData.h (+1/-1)
launcher/ExpoLauncherIcon.cpp (+64/-0)
launcher/ExpoLauncherIcon.h (+45/-0)
launcher/FavoriteStore.cpp (+93/-4)
launcher/FavoriteStore.h (+21/-8)
launcher/FavoriteStoreGSettings.cpp (+67/-68)
launcher/FavoriteStoreGSettings.h (+7/-4)
launcher/FavoriteStorePrivate.cpp (+14/-0)
launcher/FavoriteStorePrivate.h (+3/-1)
launcher/HudLauncherIcon.cpp (+2/-1)
launcher/Launcher.cpp (+83/-108)
launcher/Launcher.h (+5/-8)
launcher/LauncherController.cpp (+526/-341)
launcher/LauncherController.h (+1/-3)
launcher/LauncherControllerPrivate.h (+28/-41)
launcher/LauncherIcon.cpp (+31/-4)
launcher/LauncherIcon.h (+5/-9)
launcher/LauncherModel.cpp (+34/-32)
launcher/MockLauncherIcon.h (+11/-15)
launcher/SoftwareCenterLauncherIcon.cpp (+27/-38)
launcher/SoftwareCenterLauncherIcon.h (+1/-1)
launcher/SpacerLauncherIcon.cpp (+1/-1)
launcher/SpacerLauncherIcon.h (+0/-4)
launcher/StandaloneLauncher.cpp (+1/-1)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+34/-4)
launcher/VolumeLauncherIcon.h (+3/-0)
manual-tests/Launcher.txt (+15/-0)
panel/PanelMenuView.h (+0/-1)
plugins/unityshell/src/unityshell.cpp (+5/-7)
plugins/unityshell/unityshell.xml.in (+0/-6)
tests/CMakeLists.txt (+19/-11)
tests/gmockvolume.c (+4/-3)
tests/test_bamf_launcher_icon.cpp (+70/-2)
tests/test_bfb_launcher_icon.cpp (+11/-8)
tests/test_desktop_launcher_icon.cpp (+80/-0)
tests/test_desktop_utilities.cpp (+52/-22)
tests/test_device_launcher_section.cpp (+19/-54)
tests/test_expo_launcher_icon.cpp (+58/-0)
tests/test_favorite_store.cpp (+111/-0)
tests/test_favorite_store_gsettings.cpp (+52/-29)
tests/test_hud_launcher_icon.cpp (+53/-0)
tests/test_launcher.cpp (+226/-15)
tests/test_launcher_controller.cpp (+1246/-44)
tests/test_launcher_icon.cpp (+113/-0)
tests/test_launcher_model.cpp (+182/-40)
tests/test_main.cpp (+1/-0)
tests/test_main_xless.cpp (+1/-1)
tests/test_mock_devices.h (+93/-0)
tests/test_software_center_launcher_icon.cpp (+74/-0)
tests/test_trash_launcher_icon.cpp (+39/-0)
tests/test_volume_launcher_icon.cpp (+67/-46)
unity-shared/PluginAdapter.h (+2/-0)
unity-shared/PluginAdapterCompiz.cpp (+5/-0)
unity-shared/PluginAdapterStandalone.cpp (+15/-7)
unity-shared/WindowManager.cpp (+5/-0)
unity-shared/WindowManager.h (+1/-0)
unity-standalone/StandaloneUnity.cpp (+2/-2)
- Michal Hruby (community): Approve
-
Diff: 54 lines (+20/-6)2 files modifiedsrc/unity-launcher.vala (+17/-5)
test/vala/test-launcher-integration.vala (+3/-1)
description: | updated |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Low |
status: | New → Fix Committed |
tags: | added: udo |
description: | updated |
Changed in unity: | |
status: | New → Confirmed |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-2d: | |
status: | New → Confirmed |
Changed in unity-2d: | |
importance: | Undecided → Low |
Changed in unity: | |
importance: | Undecided → Medium |
assignee: | nobody → Jason Smith (jassmith) |
Changed in unity-2d: | |
importance: | Low → Medium |
Changed in unity-2d (Ubuntu): | |
status: | New → Confirmed |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
assignee: | Jason Smith (jassmith) → Unity Community Hackers (unity-community-hackers) |
milestone: | none → backlog |
tags: | added: backlog |
description: | updated |
description: | updated |
Changed in unity-2d (Ubuntu): | |
importance: | Undecided → Medium |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
summary: |
- [launcher] Workspace Switcher icon cannot be moved + [launcher] All launcher icons should be moveable except trash |
tags: | added: udp |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
summary: |
- [launcher] All launcher icons should be moveable except trash + [launcher] All launcher icons should be moveable except trash and BFB |
Changed in unity: | |
assignee: | Unity Community Hackers (unity-community-hackers) → nobody |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
description: | updated |
Changed in ayatana-design: | |
importance: | Low → High |
Changed in unity: | |
status: | Confirmed → Triaged |
Changed in unity-2d (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in unity: | |
assignee: | nobody → Andrea Cimitan (cimi) |
Changed in unity: | |
assignee: | Andrea Cimitan (cimi) → the Bora Bora squad (borabora) |
Changed in unity: | |
assignee: | Bora Bora (borabora) → Renato Araujo Oliveira Filho (renatofilho) |
Changed in unity: | |
assignee: | Renato Araujo Oliveira Filho (renatofilho) → nobody |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | backlog → 6.6 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Fix Committed → In Progress |
Changed in unity (Ubuntu): | |
status: | In Progress → Triaged |
Changed in unity: | |
status: | Fix Committed → In Progress |
Changed in unity-2d: | |
importance: | Medium → Wishlist |
Changed in unity-2d (Ubuntu): | |
importance: | Medium → Wishlist |
status: | Triaged → Won't Fix |
Changed in unity-2d: | |
status: | Confirmed → Triaged |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
summary: |
- [launcher] All launcher icons should be moveable except trash and BFB + [FFE] [launcher] All launcher icons should be moveable except trash and + BFB |
summary: |
- [FFE] [launcher] All launcher icons should be moveable except trash and - BFB + [FFE] All launcher icons should be moveable except trash and BFB |
description: | updated |
description: | updated |
description: | updated |
Changed in unity (Ubuntu): | |
milestone: | none → ubuntu-12.10-beta-2 |
Changed in unity: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
no longer affects: | unity/7.0 |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
no longer affects: | unity-2d (Ubuntu) |
tags: |
added: reviewedbydesignq removed: udo udp |
Changed in unity-2d: | |
status: | Triaged → Invalid |
You are talking about Unity and not Unity-2d correct?