Comment 7 for bug 1654761

On Thu, Mar 08, 2018 at 06:16:27PM -0000, Simon Quigley wrote:
> However, what also needs to be figured out is a stable way to access the
> queue items (read only is all that's needed) from Britney. This is
> because Britney sends the test directly to AMQP rather than going
> through request.cgi. So once duplicate tests can't be triggered (i.e.
> the above bug is fixed), it would certainly be confusing if these things
> show up in excuses but triggering them doesn't work (or even worse, they
> show as passed). You mentioned grabbing the data from queues.json, what
> about this isn't ideal, and what can be improved? (Because that's likely
> the way to go here.)

I think you overstate how important that is. It's not that annoying to
see an error. You want to queue a test, you click, you find out it's
already queued. Woohoo.

update_excuses is not a live page. If you click the link, its state will
not be reflected in the page until the next refresh which in the
non-busy case is probably going to be after the test has run anyway. And
then --- what if the test in progress when the page was generated
finishes and fails before the next refresh? In this proposed design
there's no button.

In my opinion we should leave update_excuses.html alone. It'd have to be
done with JS to be done properly, but then we need to figure out how to
stream the queue/running to clients and implement a whole pile of stuff
in the page to hide and show the buttons.

Cheers,

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]