Make sure duplicate tests cannot be queued
Bug #1654761 reported by
Timo Jyrinki
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Auto Package Testing |
Fix Released
|
High
|
Simon Quigley | ||
britney |
Opinion
|
Undecided
|
Simon Quigley |
Bug Description
It is a bit too easy to request a retry of a regressing test on excuses page even if one would be queued already. One option to cure this would be to change "Regression" to "Queued" once a retry is queued, instead of keeping it as "Regression" with the retry link until it is actually running.
Or more simply, remove the retry link when one is already queued.
Also, consider making request.cgi aware of the queue so that we can avoid triggering multiple test runs with the same parameters at the same time.
Related branches
~andersson123/autopkgtest-cloud:no_queue_duplicate_requests
- Brian Murray: Approve
-
Diff: 173 lines (+118/-1)2 files modifiedcharms/focal/autopkgtest-web/webcontrol/request/app.py (+3/-1)
charms/focal/autopkgtest-web/webcontrol/request/submit.py (+115/-0)
~tsimonq2/autopkgtest-cloud/+git/bug-1654761:disallow-duplicate-tests
Rejected
for merging
into
autopkgtest-cloud:master
- Brian Murray: Needs Fixing
- Łukasz Zemczak: Needs Fixing
- Steve Langasek: Needs Information
- Iain Lane: Pending requested
-
Diff: 100 lines (+70/-0)2 files modifiedwebcontrol/request/inprogress.py (+62/-0)
webcontrol/request/submit.py (+8/-0)
Changed in auto-package-testing: | |
status: | New → Confirmed |
assignee: | nobody → Simon Quigley (tsimonq2) |
summary: |
- Use another status for retried but queued items + Use another status for retried but queued items and make sure duplicate + tests cannot be queued |
description: | updated |
summary: |
- Use another status for retried but queued items and make sure duplicate - tests cannot be queued + Make sure duplicate tests cannot be queued |
tags: | added: adt-298 |
Changed in auto-package-testing: | |
importance: | Undecided → High |
Changed in auto-package-testing: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This actually isn't an issue with the autopkgtest infra on first glance; the bulk of work will need to be done in britney2's autopkgtest policy.