Comment 296 for bug 582809

Revision history for this message
In , RogutÄ—s (rogutes) wrote :

Jesse Jaara: looks like the first 2 patches were written by Takashi Iwai, but you posted them without any attribution (and thus they appear to be written by you, which is not right).

The first 2 patches and much more were reviewed by Peter Hutterer and others [1], but Takashi Iwai didn't follow up.

[1] http://lists.x.org/archives/xorg-devel/2010-October/thread.html#13821

I have an HP ProBook 4530s. Its touchpad has normal hardware buttons, and has a LED-button in the top left. Everything except the LED works without any patches. The LED needs patches to the kernel and to xf86-input-synaptics. Takashi Iwai submitted the kernel patch [2] (3rd patch posted by Jesse Jaara), got it reviewed and sent fixes, but it was not merged (forgotten?). I tried [2] + LED patches from [3] and the LED-button worked nicely...

[2] http://lkml.org/lkml/2010/4/22/35
[3] https://build.opensuse.org/package/files?package=xorg-x11-driver-input&project=openSUSE%3AFactory