Merge lp:~widelands-dev/widelands/soldierselect_radiobutton into lp:widelands

Looks good and works great. I also like those new icons.
Should there be such option for training sites as well, so we can choose to train rookies or heroes ? I have no idea if the underlying logic could allow this

About trainingsites: How should these options differ?

Currently, there is an option regarding whether the trainingsite attempts to train least-trained guy or most-trained guy, if there are more than one tha could be trained in a step. There is no UI for that.

Also, it would be relatively easy to switch on/off the whole premature soldier-layoff feature.

> Should there be such option for training sites as well, so we can choose to train rookies or heroes?
With teppos recent changes I think we have these bases covered - at least we should gather some experience before we go ahead and tweak there again. So I think for now we should not further touch trainingsites at all.

> Also, it would be relatively easy to switch on/off the whole premature soldier-layoff feature.
No way - we have barely any experience with it and I think it is a good idea.

Thanks for the review. I'll merge this soonish then. Or are there more comments?

I agree that the new buttons look really good, and that their placement is good as well.

However, start and stop buttons have now appeared to the lower left corner. Those should not be present in militarysites. Without this check, "Stop" and "Continue" buttons are not presented. The patch should not remove that check as it does now.

typo: "Without this check" -> "Without this patch"

Clarifying myself further: I would change soldierselect_radiobutton/6667 like below. This is a bit ugly, but I somehow just lost the attach-file button..:

=== modified file 'src/wui/buildingwindow.cc'
--- old/src/wui/buildingwindow.cc 2013-07-24 20:52:13 +0000
+++ new/src/wui/buildingwindow.cc 2013-07-27 08:48:17 +0000
@@ -196,7 +196,8 @@
                        }
                }
                else
- if (upcast(const Widelands::ProductionSite, productionsite, &m_building)) {
+ if (upcast(const Widelands::ProductionSite, productionsite, &m_building))
+ if (not dynamic_cast<const Widelands::MilitarySite *>(productionsite)) {
                        const bool is_stopped = productionsite->is_stopped();
                        UI::Button * stopbtn =
                                new UI::Button

> I agree that the new buttons look really good, and that their placement is good as well.
Thanks! Glad that you like it that way too.

> However, start and stop buttons have now appeared to the lower left corner.
Good catch - I messed that up. I added something along the lines of your patch and merged the branch.

> not dynamic_cast<const Widelands::MilitarySite *>(productionsite)
btw, we have a convenience macro for this is_a(Widelands::Militarysite, productionsite)